* [libgpiod][PATCH] tools: gpioset: remove pointless whitespace
@ 2022-12-07 9:39 Kent Gibson
2022-12-07 10:16 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Kent Gibson @ 2022-12-07 9:39 UTC (permalink / raw)
To: linux-gpio, brgl; +Cc: Kent Gibson
Remove pointless whitespace in interact().
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
tools/gpioset.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/gpioset.c b/tools/gpioset.c
index c49d229..68b3922 100644
--- a/tools/gpioset.c
+++ b/tools/gpioset.c
@@ -842,8 +842,7 @@ static void interact(struct gpiod_line_request **requests,
}
printf("unknown command: '%s'\n", words[0]);
- printf("Try the 'help' command\n")
- ;
+ printf("Try the 'help' command\n");
cmd_ok:
for (i = 0; isspace(line[i]); i++)
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [libgpiod][PATCH] tools: gpioset: remove pointless whitespace
2022-12-07 9:39 [libgpiod][PATCH] tools: gpioset: remove pointless whitespace Kent Gibson
@ 2022-12-07 10:16 ` Bartosz Golaszewski
2022-12-07 10:25 ` Kent Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2022-12-07 10:16 UTC (permalink / raw)
To: Kent Gibson; +Cc: linux-gpio
On Wed, Dec 7, 2022 at 10:39 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> Remove pointless whitespace in interact().
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
> tools/gpioset.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/gpioset.c b/tools/gpioset.c
> index c49d229..68b3922 100644
> --- a/tools/gpioset.c
> +++ b/tools/gpioset.c
> @@ -842,8 +842,7 @@ static void interact(struct gpiod_line_request **requests,
> }
>
> printf("unknown command: '%s'\n", words[0]);
> - printf("Try the 'help' command\n")
> - ;
> + printf("Try the 'help' command\n");
>
> cmd_ok:
> for (i = 0; isspace(line[i]); i++)
> --
> 2.38.1
>
I've already fixed that automatically with my clang-format sweep of
the tree, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [libgpiod][PATCH] tools: gpioset: remove pointless whitespace
2022-12-07 10:16 ` Bartosz Golaszewski
@ 2022-12-07 10:25 ` Kent Gibson
0 siblings, 0 replies; 3+ messages in thread
From: Kent Gibson @ 2022-12-07 10:25 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: linux-gpio
On Wed, Dec 07, 2022 at 11:16:19AM +0100, Bartosz Golaszewski wrote:
> On Wed, Dec 7, 2022 at 10:39 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > Remove pointless whitespace in interact().
> >
> > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > ---
> > tools/gpioset.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/tools/gpioset.c b/tools/gpioset.c
> > index c49d229..68b3922 100644
> > --- a/tools/gpioset.c
> > +++ b/tools/gpioset.c
> > @@ -842,8 +842,7 @@ static void interact(struct gpiod_line_request **requests,
> > }
> >
> > printf("unknown command: '%s'\n", words[0]);
> > - printf("Try the 'help' command\n")
> > - ;
> > + printf("Try the 'help' command\n");
> >
> > cmd_ok:
> > for (i = 0; isspace(line[i]); i++)
> > --
> > 2.38.1
> >
>
> I've already fixed that automatically with my clang-format sweep of
> the tree, thanks!
>
Haha, so you have. Nice.
Cheers,
Kent.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-07 10:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-07 9:39 [libgpiod][PATCH] tools: gpioset: remove pointless whitespace Kent Gibson
2022-12-07 10:16 ` Bartosz Golaszewski
2022-12-07 10:25 ` Kent Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).