From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
chrome-platform@lists.linux.dev,
linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail
Date: Sun, 11 Dec 2022 15:31:25 +0200 [thread overview]
Message-ID: <Y5XbrWTicuTxPLwN@smile.fi.intel.com> (raw)
In-Reply-To: <20221210224154.733cd5qnrkpexq22@pengutronix.de>
On Sat, Dec 10, 2022 at 11:41:54PM +0100, Uwe Kleine-König wrote:
> On Sat, Dec 10, 2022 at 10:57:16PM +0200, Andy Shevchenko wrote:
> > On Sat, Dec 10, 2022 at 10:18:33AM +0100, Uwe Kleine-König wrote:
> > > On Fri, Dec 09, 2022 at 11:47:54PM +0200, Andy Shevchenko wrote:
> > > > On Wed, Nov 30, 2022 at 04:21:37PM +0100, Uwe Kleine-König wrote:
...
> > > > I'm wondering why we didn't see a compiler warning about mistyped function
> > > > prototypes in some drivers.
> > >
> > > I don't understand where you expected a warning. Care to elaborate?
> >
> > intel-lpss.c has the prototype that returns an int. IIRC it was like this
>
> Do you mean drivers/mfd/intel-lpss.c? That one doesn't implement a PWM?!
Nope, I meant pwm-lpss.c.
> And drivers/pwm/pwm-lpss.c is adapted by this series.
That's what I didn't see how.
> One of us is confused ...
Yes, because when I have checked the branch based on Linux Next I already saw
that get_state() returns a code and I wasn't aware that the series is already
there.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-11 13:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 15:21 [PATCH v2 00/11] pwm: Allow .get_state to fail Uwe Kleine-König
2022-11-30 15:21 ` [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Uwe Kleine-König
2022-12-01 1:17 ` Baolin Wang
2022-12-01 2:41 ` Tzung-Bi Shih
2022-12-01 8:03 ` Neil Armstrong
2022-12-01 9:30 ` nobuhiro1.iwamatsu
2022-12-01 10:22 ` Andre Przywara
2022-12-01 13:16 ` Uwe Kleine-König
2022-12-01 14:17 ` Andre Przywara
2022-12-01 10:43 ` Dave Stevenson
2022-12-01 15:37 ` Doug Anderson
2022-12-05 20:50 ` Jernej Škrabec
2022-12-05 22:30 ` Pavel Machek
2022-12-01 11:11 ` [PATCH v2 00/11] pwm: Allow .get_state to fail Conor Dooley
2022-12-01 13:19 ` Uwe Kleine-König
2022-12-01 13:28 ` Conor Dooley
2022-12-09 21:47 ` Andy Shevchenko
2022-12-10 9:18 ` Uwe Kleine-König
2022-12-10 20:57 ` Andy Shevchenko
2022-12-10 22:41 ` Uwe Kleine-König
2022-12-11 13:31 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5XbrWTicuTxPLwN@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=chrome-platform@lists.linux.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).