From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][PATCH] tools: tests: remove leftover echo
Date: Mon, 12 Dec 2022 17:48:37 +0800 [thread overview]
Message-ID: <Y5b49f+zuaDR2dES@sol> (raw)
In-Reply-To: <20221212093510.146129-1-brgl@bgdev.pl>
On Mon, Dec 12, 2022 at 10:35:10AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This looks like some unneeded leftover from the development that was
> missed because bats intercepts all echo output.
>
Indeed - you only see it when a test fails, and I obviously missed
removing it after getting the offending test to pass.
Reviewed-by: Kent Gibson <warthog618@gmail.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> tools/gpio-tools-test.bats | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats
> index bf7f3d6..adbce94 100755
> --- a/tools/gpio-tools-test.bats
> +++ b/tools/gpio-tools-test.bats
> @@ -392,7 +392,6 @@ request_release_line() {
>
> run_tool gpioinfo
>
> - echo "$output"
> output_contains_line "${GPIOSIM_CHIP_NAME[sim0]} - 4 lines:"
> output_contains_line "${GPIOSIM_CHIP_NAME[sim1]} - 8 lines:"
> output_regex_match "\\s+line\\s+0:\\s+unnamed\\s+input"
> --
> 2.37.2
>
prev parent reply other threads:[~2022-12-12 9:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 9:35 [libgpiod][PATCH] tools: tests: remove leftover echo Bartosz Golaszewski
2022-12-12 9:48 ` Kent Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5b49f+zuaDR2dES@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).