* [libgpiod][PATCH] tools: tests: remove leftover echo
@ 2022-12-12 9:35 Bartosz Golaszewski
2022-12-12 9:48 ` Kent Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2022-12-12 9:35 UTC (permalink / raw)
To: Kent Gibson, Linus Walleij, Andy Shevchenko, Viresh Kumar
Cc: linux-gpio, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This looks like some unneeded leftover from the development that was
missed because bats intercepts all echo output.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
tools/gpio-tools-test.bats | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats
index bf7f3d6..adbce94 100755
--- a/tools/gpio-tools-test.bats
+++ b/tools/gpio-tools-test.bats
@@ -392,7 +392,6 @@ request_release_line() {
run_tool gpioinfo
- echo "$output"
output_contains_line "${GPIOSIM_CHIP_NAME[sim0]} - 4 lines:"
output_contains_line "${GPIOSIM_CHIP_NAME[sim1]} - 8 lines:"
output_regex_match "\\s+line\\s+0:\\s+unnamed\\s+input"
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [libgpiod][PATCH] tools: tests: remove leftover echo
2022-12-12 9:35 [libgpiod][PATCH] tools: tests: remove leftover echo Bartosz Golaszewski
@ 2022-12-12 9:48 ` Kent Gibson
0 siblings, 0 replies; 2+ messages in thread
From: Kent Gibson @ 2022-12-12 9:48 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, Andy Shevchenko, Viresh Kumar, linux-gpio,
Bartosz Golaszewski
On Mon, Dec 12, 2022 at 10:35:10AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This looks like some unneeded leftover from the development that was
> missed because bats intercepts all echo output.
>
Indeed - you only see it when a test fails, and I obviously missed
removing it after getting the offending test to pass.
Reviewed-by: Kent Gibson <warthog618@gmail.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> tools/gpio-tools-test.bats | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats
> index bf7f3d6..adbce94 100755
> --- a/tools/gpio-tools-test.bats
> +++ b/tools/gpio-tools-test.bats
> @@ -392,7 +392,6 @@ request_release_line() {
>
> run_tool gpioinfo
>
> - echo "$output"
> output_contains_line "${GPIOSIM_CHIP_NAME[sim0]} - 4 lines:"
> output_contains_line "${GPIOSIM_CHIP_NAME[sim1]} - 8 lines:"
> output_regex_match "\\s+line\\s+0:\\s+unnamed\\s+input"
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-12 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-12 9:35 [libgpiod][PATCH] tools: tests: remove leftover echo Bartosz Golaszewski
2022-12-12 9:48 ` Kent Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).