From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Hawa, Hanna" <hhhawa@amazon.com>
Cc: wsa@kernel.org, linus.walleij@linaro.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, dwmw@amazon.co.uk, benh@amazon.com,
ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, farbere@amazon.com, itamark@amazon.com
Subject: Re: [PATCH v3 1/1] i2c: Set pinctrl recovery info to device pinctrl
Date: Wed, 21 Dec 2022 18:59:04 +0200 [thread overview]
Message-ID: <Y6M7WEMwSSndugE3@smile.fi.intel.com> (raw)
In-Reply-To: <a82ba757-3b9c-d54b-76bf-ceef84239295@amazon.com>
On Tue, Dec 20, 2022 at 09:32:11PM +0200, Hawa, Hanna wrote:
> On 12/20/2022 9:18 PM, Andy Shevchenko wrote:
> > > How you suggest to simplify this?
> > Using Elvis operator, which is ?:.
>
> Are you refer to use 'return dev->pins && dev->pins->p ?: NULL;' ?
> Can't use Elvis operator in this way, because it will return the result of
> 'dev->pins && dev->pins->p' and not the value of 'dev->pins->p'
I see now. Then we need to check pins separately, something like
if (!dev->pins)
return NULL;
return dev->pins->p;
Sorry that I haven't noticed that before.
> > > I can use 'return dev->pins ? dev->pins->p ?: dev->pins->p : NULL;'
> > Have you even try to compile this?
> Yup, the code compiled, but i think the first suggestion is more readable.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-21 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 19:32 [PATCH v3 1/1] i2c: Set pinctrl recovery info to device pinctrl Hanna Hawa
2022-12-20 6:23 ` kernel test robot
2022-12-20 6:43 ` kernel test robot
2022-12-20 8:43 ` Hawa, Hanna
2022-12-20 10:53 ` Andy Shevchenko
2022-12-20 17:07 ` Hawa, Hanna
2022-12-20 19:18 ` Andy Shevchenko
2022-12-20 19:32 ` Hawa, Hanna
2022-12-21 16:59 ` Andy Shevchenko [this message]
2022-12-20 10:57 ` Andy Shevchenko
2022-12-20 17:08 ` Hawa, Hanna
2022-12-20 13:03 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6M7WEMwSSndugE3@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).