From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][PATCH] core: make the library NULL-aware
Date: Mon, 9 Jan 2023 13:30:28 +0200 [thread overview]
Message-ID: <Y7v61HBtu1cPOS2D@smile.fi.intel.com> (raw)
In-Reply-To: <Y7v6oWaNVgltjC8V@smile.fi.intel.com>
On Mon, Jan 09, 2023 at 01:29:37PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 06, 2023 at 12:51:29PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
...
> > GPIOD_API void gpiod_line_config_free(struct gpiod_line_config *config)
> > {
> > + if (!config)
> > + return;
> > +
> > free_refs(config);
> > free(config);
> > }
>
> At least this is redundant. free() is NULL-aware itself.
And if free_refs() is not, it's better to make it explicit or fix that function
if possible.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-09 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 11:51 [libgpiod][PATCH] core: make the library NULL-aware Bartosz Golaszewski
2023-01-09 11:29 ` Andy Shevchenko
2023-01-09 11:30 ` Andy Shevchenko [this message]
2023-01-09 17:36 ` Bartosz Golaszewski
2023-01-09 17:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7v61HBtu1cPOS2D@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).