From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2576C433E6 for ; Thu, 21 Jan 2021 05:57:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CEFE2389B for ; Thu, 21 Jan 2021 05:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725922AbhAUF5k (ORCPT ); Thu, 21 Jan 2021 00:57:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727954AbhAUDUv (ORCPT ); Wed, 20 Jan 2021 22:20:51 -0500 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7BBEC0613D3 for ; Wed, 20 Jan 2021 19:19:16 -0800 (PST) Received: by mail-ot1-x32c.google.com with SMTP id f6so331219ots.9 for ; Wed, 20 Jan 2021 19:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8Rp2B5BZv6lIw+nnY7lV34RDMnSmVwqnPc777cf3U+0=; b=NkEj1mMXhbaRzvPldVQpLi/kkm1Us5mKQIOA/B/990oJQ4XtITyBH/fAUUlE1dojJ0 3rie8SnB27VwwuiKeU5NO+MUJP4bHPUZ8z5G8qsKMJlRYEZAtXtqY4RGuH8R3WrdHU4v ifDwv0kYQUpDExwhpS7L71jrQSxPQYIQOd4C8YAkSVbGk1EStVpi1oVZTXmKONffxmAm X8Z5ULAUv9cPbXt5C2fczkQ+oIqSxZw+iH4tI0ThK0a9WBqQLRpGF5bXD7JKYUW1qBG+ oA24oxYApDNvZMAsM8i6kGMQtL+TiUdDoV3+RzGIl3RLPIBRTKOPSpY9D5zvoseEoFHz pIiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8Rp2B5BZv6lIw+nnY7lV34RDMnSmVwqnPc777cf3U+0=; b=Rbriwxn9gfR+Tgv9kPrUVCT0IxqZyeWEtnQEblLUT//x6OgxDhMzbQPimb31crtK0O U1+cehzHslEDH09i/vUFLao2/VphmFqQ+rDm2rgNHdgeAOLk8RAoZn7HzvDBiamZnYth izpET458UN6hTPEU6SoOjfQWjvuXHU8UyjXoQOTthTCUxQ1Nxa2sRoXsnjNO9IHYvFni dxCuzM2qyJT4xUojGf+LseS/bwqr8UjxMHyPya+N+jGxH0z18wr/3vITkqTzMOr7VWdr /HcmJLwmrPZQ0poLV3L2Y72EiKqIFujjTz6RlxbuCWWHbf+KhPk3PtClXokZLhZMDd4j 3NeA== X-Gm-Message-State: AOAM532vsZEqRYDvEE9iAjoaoyyh4Oy8hsVNHzQQ6XcSNuNlXtg5ARGh avv+qOfsE8kWALm9yxhZ36k3GjEXL5iMGg== X-Google-Smtp-Source: ABdhPJxuY7waI6QdTU1Q9xQW1jHXgw+x26QczNUMzXPrT8tg4A5/nB3Md4IX8Gi545ZP+gvDQXIBtw== X-Received: by 2002:a9d:4c83:: with SMTP id m3mr596284otf.353.1611199155747; Wed, 20 Jan 2021 19:19:15 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id i1sm858689otr.81.2021.01.20.19.19.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 19:19:15 -0800 (PST) Date: Wed, 20 Jan 2021 21:19:13 -0600 From: Bjorn Andersson To: Jiapeng Zhong Cc: agross@kernel.org, linus.walleij@linaro.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom: spmi-gpio: Assign boolean values to a bool variable Message-ID: References: <1611127757-52999-1-git-send-email-abaci-bugfix@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1611127757-52999-1-git-send-email-abaci-bugfix@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed 20 Jan 01:29 CST 2021, Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c:340:3-15: WARNING: > Assignment of 0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Reviewed-by: Bjorn Andersson Although we're mixing bool/int on line 417 and 637 as well, with: val |= pin->disable; and pin->disable = val & BIT(0); respectively. The latter could be dealt with using !!(val & BIT(0)); I guess the appropriate for for the prior is: if (pin->disable) val |= BIT(0); If you would like to update your patch with these as well I'd be happy to review this. Thanks, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c > index b5949f7..eb0b60c 100644 > --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c > @@ -331,13 +331,13 @@ static int pm8xxx_pin_config_set(struct pinctrl_dev *pctldev, > case PIN_CONFIG_BIAS_DISABLE: > pin->bias = PM8XXX_GPIO_BIAS_NP; > banks |= BIT(2); > - pin->disable = 0; > + pin->disable = false; > banks |= BIT(3); > break; > case PIN_CONFIG_BIAS_PULL_DOWN: > pin->bias = PM8XXX_GPIO_BIAS_PD; > banks |= BIT(2); > - pin->disable = 0; > + pin->disable = false; > banks |= BIT(3); > break; > case PM8XXX_QCOM_PULL_UP_STRENGTH: > @@ -350,11 +350,11 @@ static int pm8xxx_pin_config_set(struct pinctrl_dev *pctldev, > case PIN_CONFIG_BIAS_PULL_UP: > pin->bias = pin->pull_up_strength; > banks |= BIT(2); > - pin->disable = 0; > + pin->disable = false; > banks |= BIT(3); > break; > case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: > - pin->disable = 1; > + pin->disable = true; > banks |= BIT(3); > break; > case PIN_CONFIG_INPUT_ENABLE: > -- > 1.8.3.1 >