From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH v2 3/5] lib/cmdline: Allow get_options() to take 0 to validate the input
Date: Fri, 22 Jan 2021 14:13:00 +0200 [thread overview]
Message-ID: <YArBTIQw2YIfeCKM@smile.fi.intel.com> (raw)
In-Reply-To: <CAMpxmJXDDeHKD9Zo32R4WD0q_3Ky40F5hkajFvyWPVzkq73khg@mail.gmail.com>
On Fri, Jan 22, 2021 at 12:15:20PM +0100, Bartosz Golaszewski wrote:
> On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > + * When @nints is 0, the function just validates the given @str and
> > + * returns amount of parseable integers as described below.
>
> I'm not a native English speaker but it sounds like this should be
> "returns the amount".
Sounds reasonable. Fixed for v3.
...
> > + bool validate = nints == 0;
>
> bool validate = (nints == 0) would be clearer IMO.
I don't see the benefit, but I have changed.
...
> Same as the other patch - just put the formatting strings into the messages.
Okay, I changed.
Thanks for review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-22 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 21:45 [PATCH v2 1/5] lib/cmdline_kunit: add a new test case for get_options() Andy Shevchenko
2021-01-20 21:45 ` [PATCH v2 2/5] lib/cmdline: Update documentation to reflect behaviour Andy Shevchenko
2021-01-22 11:12 ` Bartosz Golaszewski
2021-01-20 21:45 ` [PATCH v2 3/5] lib/cmdline: Allow get_options() to take 0 to validate the input Andy Shevchenko
2021-01-22 11:15 ` Bartosz Golaszewski
2021-01-22 12:13 ` Andy Shevchenko [this message]
2021-01-20 21:45 ` [PATCH v2 4/5] gpio: aggregator: Replace isrange() by using get_options() Andy Shevchenko
2021-01-21 13:17 ` Linus Walleij
2021-01-22 10:47 ` Bartosz Golaszewski
2021-01-20 21:45 ` [PATCH v2 5/5] gpio: aggregator: Remove trailing comma in terminator entries Andy Shevchenko
2021-01-21 13:17 ` Linus Walleij
2021-01-21 17:09 ` Andy Shevchenko
2021-01-22 10:46 ` Bartosz Golaszewski
2021-01-22 10:46 ` Bartosz Golaszewski
2021-01-22 10:50 ` Geert Uytterhoeven
2021-01-22 11:11 ` [PATCH v2 1/5] lib/cmdline_kunit: add a new test case for get_options() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YArBTIQw2YIfeCKM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).