From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
luojiaxing <luojiaxing@huawei.com>,
Linus Walleij <linus.walleij@linaro.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>
Subject: Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()
Date: Fri, 12 Feb 2021 13:35:22 +0200 [thread overview]
Message-ID: <YCZn+idf9A7OpKbb@smile.fi.intel.com> (raw)
In-Reply-To: <CAK8P3a0aNfF5D+y--5-reBYO2svykCJFxpZ=1dJoK5JDGHPqKw@mail.gmail.com>
On Fri, Feb 12, 2021 at 11:59:28AM +0100, Arnd Bergmann wrote:
> On Fri, Feb 12, 2021 at 11:42 AM Song Bao Hua (Barry Song)
> <song.bao.hua@hisilicon.com> wrote:
> >
> > Ok, second thought. irqsave before generic_handle_irq() won't defeat
> > the purpose of preemption too much as the dispatched irq handlers by
> > gpiochip will run in their own threads but not in the thread of
> > gpiochip's handler.
> >
> > so looks like this patch can improve by:
> > * move other raw_spin_lock_irqsave to raw_spin_lock;
> > * keep the raw_spin_lock_irqsave before generic_handle_irq() to mute
> > the warning in genirq.
>
> It seems that the other drivers just call handle_nested_irq() instead
> of generic_handle_irq().
And IIRC all of them request threaded IRQ explicitly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-12 11:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 8:56 [PATCH for next v1 0/2] gpio: few clean up patches to replace spin_lock_irqsave with spin_lock Luo Jiaxing
2021-02-08 8:56 ` [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler() Luo Jiaxing
2021-02-11 18:14 ` Grygorii Strashko
2021-02-11 19:39 ` Arnd Bergmann
2021-02-11 20:16 ` Grygorii Strashko
[not found] ` <a61ef337fd1c4538a47fe855920f95d3@hisilicon.com>
[not found] ` <CAK8P3a3SHQNjF5ZpqHQweG7BQ52Xi1hQKDiMVKq4aNK_7VDw6w@mail.gmail.com>
2021-02-12 10:27 ` [Linuxarm] " Grygorii Strashko
2021-02-12 10:42 ` Song Bao Hua (Barry Song)
2021-02-12 10:57 ` Andy Shevchenko
2021-02-12 11:29 ` Song Bao Hua (Barry Song)
2021-02-12 11:53 ` Grygorii Strashko
2021-02-12 13:12 ` Song Bao Hua (Barry Song)
2021-02-12 14:08 ` Grygorii Strashko
2021-02-12 20:06 ` Song Bao Hua (Barry Song)
2021-02-12 20:23 ` Arnd Bergmann
2021-02-12 20:49 ` Song Bao Hua (Barry Song)
2021-02-12 10:59 ` Arnd Bergmann
2021-02-12 11:35 ` Andy Shevchenko [this message]
2021-02-08 9:11 ` [Linuxarm] [PATCH for next v1 0/2] gpio: few clean up patches to replace spin_lock_irqsave with spin_lock luojiaxing
2021-02-08 13:28 ` Andy Shevchenko
2021-02-09 9:24 ` luojiaxing
2021-02-09 9:42 ` Andy Shevchenko
2021-02-10 3:43 ` luojiaxing
2021-02-10 10:50 ` Andy Shevchenko
2021-02-10 11:50 ` [Linuxarm] " Song Bao Hua (Barry Song)
2021-02-10 14:56 ` Andy Shevchenko
2021-02-10 20:42 ` Song Bao Hua (Barry Song)
2021-02-11 9:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCZn+idf9A7OpKbb@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=arnd@kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=luojiaxing@huawei.com \
--cc=song.bao.hua@hisilicon.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).