From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] pinctrl: qcom: handle tiles for ACPI boot
Date: Wed, 3 Mar 2021 16:08:09 +0200 [thread overview]
Message-ID: <YD+YSS/s79gqwEpS@smile.fi.intel.com> (raw)
In-Reply-To: <20210303132622.4115-2-shawn.guo@linaro.org>
On Wed, Mar 03, 2021 at 09:26:21PM +0800, Shawn Guo wrote:
> It's not always the case that DT and ACPI describe hardware resource in
> the same schema, even for a single platform. For example, on SC8180X,
> DT uses the tiles schema while ACPI describe memory resource as a single
> region. It patches msm_pinctrl_probe() function to map tiles regions
> only for DT. While for ACPI, it maps the single memory resource and
> calculate tile bases with offsets passed from SoC data.
...
> +#include <linux/acpi.h>
There are at least two possibilities to avoid this:
- use is_of_node(dev_fwnode(dev)), or in case you need board files support,
!(fwnode && is_of_fwnode(fwnode))
- provide the tiles support directly from the driver thru internal data structures
And to me the second approach seems better, because there is no guarantee that
tiles support is only defined by the fwnode type.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-04 0:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 13:26 [PATCH v2 0/2] Add ACPI support for SC8180X pinctrl driver Shawn Guo
2021-03-03 13:26 ` [PATCH v2 1/2] pinctrl: qcom: handle tiles for ACPI boot Shawn Guo
2021-03-03 14:08 ` Andy Shevchenko [this message]
2021-03-03 14:45 ` Shawn Guo
2021-03-03 16:14 ` Andy Shevchenko
2021-03-04 5:24 ` Shawn Guo
2021-03-03 13:26 ` [PATCH v2 2/2] pinctrl: qcom: sc8180x: add ACPI probe support Shawn Guo
2021-03-03 14:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD+YSS/s79gqwEpS@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).