From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Christoph Hellwig" <hch@lst.de>, "Shuah Khan" <shuah@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Kent Gibson" <warthog618@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-doc <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2 09/12] gpio: sim: new testing module
Date: Mon, 8 Mar 2021 18:37:24 +0200 [thread overview]
Message-ID: <YEZSxDhREd5FBYVE@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=Mf4kmDadRgDiX=p2DuKjBXng8FWvouToQMJBNsfX2zckw@mail.gmail.com>
On Mon, Mar 08, 2021 at 04:37:10PM +0100, Bartosz Golaszewski wrote:
> On Mon, Mar 8, 2021 at 4:32 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote:
> > > On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote:
> >
> > ...
> >
> > > > I have strong opinion not to open code "yet another parser".
> > > >
> > > > So, grepping on 'strsep(.*, ",")' shows a lot of code that wants something like
> > > > this. Interesting are the net/9p cases. This in particular pointed out to
> > > > lib/parser.c which in turn shows promising match_strlcpy() / match_strdup(). I
> > > > haven't looked deeply though.
> > > >
> > > > That said, I agree that next_arg() is not the best here.
> > >
> > > Shall we revisit this once it's upstream with a generalization for
> > > separating comma separated strings?
> >
> > How can we guarantee it won't be forgotten?
> >
>
> I will add a REVISIT comment, so *obviously* it ***will*** be revisited. :)
Fine by me!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-08 16:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 10:24 [PATCH v2 00/12] gpio: implement the configfs testing module Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 01/12] configfs: increase the item name length Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 02/12] configfs: use (1UL << bit) for internal flags Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 03/12] configfs: implement committable items Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 04/12] samples: configfs: add a committable group Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 05/12] lib: bitmap: remove the 'extern' keyword from function declarations Bartosz Golaszewski
2021-03-04 12:58 ` Andy Shevchenko
2021-03-09 14:44 ` Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 06/12] lib: bitmap: order includes alphabetically Bartosz Golaszewski
2021-03-04 12:59 ` Andy Shevchenko
2021-03-04 10:24 ` [PATCH v2 07/12] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc() Bartosz Golaszewski
2021-03-04 13:01 ` Andy Shevchenko
2021-03-04 10:24 ` [PATCH v2 08/12] drivers: export device_is_bound() Bartosz Golaszewski
2021-03-05 8:18 ` Geert Uytterhoeven
2021-03-05 8:33 ` Greg KH
2021-03-05 8:45 ` Bartosz Golaszewski
2021-03-05 8:55 ` Greg KH
2021-03-05 9:16 ` Bartosz Golaszewski
2021-03-05 10:24 ` Greg KH
2021-03-05 10:58 ` Bartosz Golaszewski
2021-03-05 11:27 ` Greg KH
2021-03-05 14:20 ` Bartosz Golaszewski
2021-03-05 15:01 ` Greg KH
2021-03-08 10:58 ` Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 09/12] gpio: sim: new testing module Bartosz Golaszewski
2021-03-04 13:15 ` Andy Shevchenko
2021-03-04 20:15 ` Bartosz Golaszewski
2021-03-05 10:15 ` Andy Shevchenko
2021-03-08 14:23 ` Bartosz Golaszewski
2021-03-08 15:04 ` Andy Shevchenko
2021-03-08 15:13 ` Bartosz Golaszewski
2021-03-08 15:32 ` Andy Shevchenko
2021-03-08 15:37 ` Bartosz Golaszewski
2021-03-08 16:37 ` Andy Shevchenko [this message]
2021-03-04 10:24 ` [PATCH v2 10/12] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 11/12] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-03-04 10:24 ` [PATCH v2 12/12] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEZSxDhREd5FBYVE@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).