From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Shawn Guo <shawn.guo@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] pinctrl: qcom: sc8180x: add ACPI probe support
Date: Mon, 8 Mar 2021 17:42:09 -0600 [thread overview]
Message-ID: <YEa2UWn26IMg1fii@builder.lan> (raw)
In-Reply-To: <adf598dc-d000-15d1-d14d-b782455507f2@somainline.org>
On Sun 07 Mar 05:54 CST 2021, Konrad Dybcio wrote:
> Hi,
>
> >
> > +static const int sc8180x_acpi_reserved_gpios[] = {
> > + 0, 1, 2, 3,
> > + 47, 48, 49, 50,
> > + 126, 127, 128, 129,
> > + -1 /* terminator */
> > +};
> > +
> These can vary per device (unless Qualcomm is enforcing something on
> the SC platform), so I don't think hardcoding is a good option.. Isn't
> there any data being passed on which ones should not be touched?
>
You're right, this is both ugly and error prone.
But we looked at the same when we added support for the 845 laptops but
where not able to find anything useful. On qdx2xxx the solution was to
pass a list of GPIOs that should be exposed by the driver, and only
those are made available, but nothing like this exist on the WoS devices.
Regards,
Bjorn
next prev parent reply other threads:[~2021-03-08 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 6:05 [PATCH v3 0/2] Add ACPI support for SC8180X pinctrl driver Shawn Guo
2021-03-04 6:05 ` [PATCH v3 1/2] pinctrl: qcom: sc8180x: drop the use of tiles Shawn Guo
2021-03-09 1:08 ` Bjorn Andersson
2021-03-09 2:56 ` Shawn Guo
2021-03-09 3:42 ` Bjorn Andersson
2021-03-10 10:37 ` Shawn Guo
2021-03-04 6:05 ` [PATCH v3 2/2] pinctrl: qcom: sc8180x: add ACPI probe support Shawn Guo
2021-03-04 12:44 ` Andy Shevchenko
2021-03-07 11:54 ` Konrad Dybcio
2021-03-08 23:42 ` Bjorn Andersson [this message]
2021-03-04 12:44 ` [PATCH v3 0/2] Add ACPI support for SC8180X pinctrl driver Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEa2UWn26IMg1fii@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=konrad.dybcio@somainline.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).