From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [libgpiod][PATCH 6/6] core: hide the GPIOD_API symbol
Date: Tue, 9 Mar 2021 17:07:30 +0200 [thread overview]
Message-ID: <YEePMkDDZA2Jxurr@smile.fi.intel.com> (raw)
In-Reply-To: <20210309132639.29069-7-brgl@bgdev.pl>
On Tue, Mar 09, 2021 at 02:26:39PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> GPIOD_API is unneccesarily polluting the user-facing headers. There's no
> advantage to having it in public files. Let's make them internal to the
> library. Upcoming modifications will also make GPIOD_BIT() redundant so
> we'll be able to remove all macros unrelated to the main functionality
> from gpiod.h.
> -libgpiodcxx_la_SOURCES = chip.cpp iter.cpp line.cpp line_bulk.cpp
> +libgpiodcxx_la_SOURCES = chip.cpp internal.h iter.cpp line.cpp line_bulk.cpp
Don't we have something like _HEADERS ?
...
> +#include "internal.hpp"
I forgot C++ approximately when I tried it first time :-)
But I'm confused between this and above file name. Do we have *.h and *.hpp
with the same name?
...
> -libgpiod_la_SOURCES = core.c helpers.c misc.c uapi/gpio.h
> +libgpiod_la_SOURCES = core.c helpers.c internal.h misc.c uapi/gpio.h
As above.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-09 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 13:26 [libgpiod][PATCH 0/6] treewide: another bunch of cleanups for v2.0 Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 1/6] treewide: simplify line lookup Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 2/6] tests: remove line bulk test cases Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 3/6] core: switch to reference counting for gpio chip objects Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 4/6] treewide: remove is_requested() and is_free() Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 5/6] treewide: kill line updating Bartosz Golaszewski
2021-03-09 13:26 ` [libgpiod][PATCH 6/6] core: hide the GPIOD_API symbol Bartosz Golaszewski
2021-03-09 15:07 ` Andy Shevchenko [this message]
2021-03-09 15:18 ` Bartosz Golaszewski
2021-03-09 15:28 ` Andy Shevchenko
2021-03-17 10:25 ` [libgpiod][PATCH 0/6] treewide: another bunch of cleanups for v2.0 Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEePMkDDZA2Jxurr@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).