linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v4 2/2] gpio: sch: Hook into ACPI SCI handler to catch GPIO edge events
Date: Tue, 16 Mar 2021 22:49:44 +0200	[thread overview]
Message-ID: <YFEZ6GYuXGaX/LP2@smile.fi.intel.com> (raw)
In-Reply-To: <20210316162613.87710-3-andriy.shevchenko@linux.intel.com>

On Tue, Mar 16, 2021 at 06:26:13PM +0200, Andy Shevchenko wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Neither the ACPI description on the Quark platform provides the required
> information is to do establish generic handling nor hardware capable of
> doing it. According to the datasheet the hardware can generate SCI events.
> Therefore, we need to hook from the driver directly into SCI handler of
> the ACPI subsystem in order to catch and report GPIO-related events.
> 
> Validated on the Quark-based IOT2000 platform.

This patch must be dropped completely. SCI handler is not correct way to do
this. The proper way (and we have already few examples in the kernel) is to
register GPE event.

It took me a while to gather all bits of this puzzle.

At least now I get an event, but kernel oopses, I'll continue debugging
tomorrow.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2021-03-16 20:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 16:26 [PATCH v4 0/2] gpio: sch: Interrupt support Andy Shevchenko
2021-03-16 16:26 ` [PATCH v4 1/2] gpio: sch: Add edge event support Andy Shevchenko
2021-03-16 16:26 ` [PATCH v4 2/2] gpio: sch: Hook into ACPI SCI handler to catch GPIO edge events Andy Shevchenko
2021-03-16 17:05   ` Andy Shevchenko
2021-03-16 20:49   ` Andy Shevchenko [this message]
2021-03-17  6:57     ` Jan Kiszka
2021-03-17  9:52       ` Andy Shevchenko
2021-03-17  9:57         ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFEZ6GYuXGaX/LP2@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).