From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Denis Turischev <denis@compulab.co.il>
Subject: Re: [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH
Date: Fri, 2 Apr 2021 21:15:03 +0300 [thread overview]
Message-ID: <YGdfJwbWEEd02IsD@smile.fi.intel.com> (raw)
In-Reply-To: <CAHp75VeARca4PzLkd+1SFr72AP=KWx3sAONPfwVSmHzjL9U+LA@mail.gmail.com>
On Fri, Apr 02, 2021 at 07:38:41PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 2, 2021 at 7:18 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Since LPC_SCH provides GPIO functionality, GPIO_SCH should depend on
> > LPC_SCH to prevent kconfig warning and build errors:
> >
> > WARNING: unmet direct dependencies detected for LPC_SCH
> > Depends on [n]: HAS_IOMEM [=y] && PCI [=n]
> > Selected by [y]:
> > - GPIO_SCH [=y] && GPIOLIB [=y] && X86 [=y] && (X86 [=y] || COMPILE_TEST [=n]) && ACPI [=y]
> >
> > and
> >
> > ../drivers/mfd/lpc_sch.c:204:1: warning: data definition has no type or storage class
> > module_pci_driver(lpc_sch_driver);
> > ^~~~~~~~~~~~~~~~~
> > ../drivers/mfd/lpc_sch.c:204:1: error: type defaults to ‘int’ in declaration of ‘module_pci_driver’ [-Werror=implicit-int]
> > ../drivers/mfd/lpc_sch.c:204:1: warning: parameter names (without types) in function declaration
> > ../drivers/mfd/lpc_sch.c:197:26: warning: ‘lpc_sch_driver’ defined but not used [-Wunused-variable]
> > static struct pci_driver lpc_sch_driver = {
> > ^~~~~~~~~~~~~~
>
> Thanks!
>
> Bart, please, take it in your tree directly, or if you wish I may
> collect this one together with Hans' one and send a PR.
Bart, nevermind. Same answer as to Hans' patch: I'll take care as usual.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-04-02 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 16:17 [PATCH -next v2] gpio: GPIO_SCH: depends on LPC_SCH Randy Dunlap
2021-04-02 16:38 ` Andy Shevchenko
2021-04-02 18:15 ` Andy Shevchenko [this message]
2021-04-02 18:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGdfJwbWEEd02IsD@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=denis@compulab.co.il \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).