From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F346C07E95 for ; Fri, 16 Jul 2021 09:43:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FD416128D for ; Fri, 16 Jul 2021 09:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232559AbhGPJpx (ORCPT ); Fri, 16 Jul 2021 05:45:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231490AbhGPJpv (ORCPT ); Fri, 16 Jul 2021 05:45:51 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B80C061760 for ; Fri, 16 Jul 2021 02:42:57 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id v5so11372460wrt.3 for ; Fri, 16 Jul 2021 02:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=i8BbHCY36HWeOSP/Mk5Bqu7RLlSCoqipz9eWFDA1two=; b=ZBE66alYfrjz+XhQBRbbqDXrP5r90PrFSpl4xoScyBAoV1nakhvb/7IuPW21/2unAk ODfRlDHH94iYoFVsWtaYeJTSb9BKItC2g7R7OEB741DgSvJpN0vjM4LaRi9kAMuSEU37 aIL6kAoG4AzxiFVNy8e6te2XZFTjAtGFtBn4AvGtOuzgKG1RDt4yS8b1WUy2mcNHOGSi 0kWL9l+i5gakl4tzknysCS72kJj+O+0mQ5C3qoxtnlExW1K3hwVVVzWyfQestBDSKzmP ifUr6m/wjKpN6o1TVGEn94Q1nVob2sZl0sPlLKhhxt4BGR9KCYFbJI2spKz7cxOcaEcL J5zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=i8BbHCY36HWeOSP/Mk5Bqu7RLlSCoqipz9eWFDA1two=; b=ZFbyfMnrBGcYF6PCqfXbXopK3nDzZaN9gBTczzWEPu6cjwAoXbCVdjcnVa1E8k9lN8 T1NpxwpHlhH/822MhPpy6ZxV35Smpvv1l3JAYO74UO3iZlJrzG8PziEPdHiBctXn0UaT 3/k7HqIE0ZWA3YhxklZUtomcqVzGlRiAgtLVirkKbTUIO65EWFv5tbKTWJZeoaR+mA9+ r0xzy/Gd0nqaWB8YGiPN2xauyS7ewTgdMjSmiXDrNl58QnMRKCTchzexOyXq+v+VRrg4 i6Dy8vgfcSZe0I54edPHeapqlk5rE1k2jzEmjz7/jH943HDU3WlCxPH+3BR+1R0wD+aA Kqzg== X-Gm-Message-State: AOAM530T1k9XVWynmpPtSlFFw9rysEGpfyy4w4YsWhZLkSIVdAolVwSl yq9E+dyHlrTBM0syyf6JByW9ig== X-Google-Smtp-Source: ABdhPJwoYjcWEpced0OKX1uPRScV2uuWCMxRE8Q2GTPEAi+F6jfJPs9gqYJ69lOcCYwTllTMBqGu5A== X-Received: by 2002:a5d:6850:: with SMTP id o16mr10875158wrw.319.1626428575912; Fri, 16 Jul 2021 02:42:55 -0700 (PDT) Received: from google.com ([31.124.24.141]) by smtp.gmail.com with ESMTPSA id w9sm7728661wmc.19.2021.07.16.02.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 02:42:55 -0700 (PDT) Date: Fri, 16 Jul 2021 10:42:53 +0100 From: Lee Jones To: Matthias Schiffer Cc: Linus Walleij , Bartosz Golaszewski , Andrew Lunn , Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/7] TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, 16 Jul 2021, Matthias Schiffer wrote: > On Fri, 2021-07-16 at 10:20 +0100, Lee Jones wrote: > > On Fri, 02 Jul 2021, Matthias Schiffer wrote: > > > > > Updated patch series: > > > > > > - A number of new patches (more hardware support and a few fixes) > > > - Patches 1-3 have gained Fixes tags > > > - Patch 2 depends on 1, so maybe we can push the GPIO patch through the > > > MFD tree to keep them together? > > > - The change in patch 7 was somewhat controversial. I've added a > > > warning, but it is the last patch of the series, so it doesn't affect > > > the rest of the series if it is rejected. > > > > > > > > > Matthias Schiffer (7): > > > gpio: tqmx86: really make IRQ optional > > > mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set > > > mfd: tqmx86: remove incorrect TQMx90UC board ID > > > mfd: tqmx86: fix typo in "platform" > > > mfd: tqmx86: add support for TQMx110EB and TQMxE40x > > > mfd: tqmx86: add support for TQ-Systems DMI IDs > > > mfd: tqmx86: assume 24MHz LPC clock for unknown boards > > > > > > drivers/gpio/gpio-tqmx86.c | 6 ++--- > > > drivers/mfd/tqmx86.c | 48 ++++++++++++++++++++++++++++++-------- > > > 2 files changed, 41 insertions(+), 13 deletions(-) > > > > Patches look good. > > > > Could you please collect up Andrew's acks, remove the suggested Fixes: > > lines and resubmit please? > > Are you referring to the Fixes: line in "[PATCH v2 3/7] mfd: tqmx86: > remove incorrect TQMx90UC board ID"? I'm referring to the lines that Andrew said did not qualify. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog