From: Tony Lindgren <tony@atomide.com>
To: Ben Hutchings <ben.hutchings@mind.be>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] gpio: omap: Enable software fallback for long debounce periods
Date: Thu, 12 Aug 2021 10:48:04 +0300 [thread overview]
Message-ID: <YRTSNGsy7gH7z2ya@atomide.com> (raw)
In-Reply-To: <20210811202751.GB18930@cephalopod>
* Ben Hutchings <ben.hutchings@mind.be> [210811 20:28]:
> omap2_set_gpio_debounce() currently returns -EINVAL if the debounce
> period is too long to be handled in hardware. gpiolib provides a
> software fallback, but it is used only if the driver returns
> -ENOTSUPP.
>
> * Enable the software fallback by using the expected error code
> * Downgrade the log message about this from info to debug, since
> the error is now handled
Looks good to me:
Reviewed-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2021-08-12 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 20:27 [PATCH] gpio: omap: Enable software fallback for long debounce periods Ben Hutchings
2021-08-12 7:48 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRTSNGsy7gH7z2ya@atomide.com \
--to=tony@atomide.com \
--cc=ben.hutchings@mind.be \
--cc=grygorii.strashko@ti.com \
--cc=khilman@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).