From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A11DC4338F for ; Thu, 12 Aug 2021 07:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AD336103A for ; Thu, 12 Aug 2021 07:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234251AbhHLHse (ORCPT ); Thu, 12 Aug 2021 03:48:34 -0400 Received: from muru.com ([72.249.23.125]:42534 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232186AbhHLHsb (ORCPT ); Thu, 12 Aug 2021 03:48:31 -0400 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 7A2C680E2; Thu, 12 Aug 2021 07:48:26 +0000 (UTC) Date: Thu, 12 Aug 2021 10:48:04 +0300 From: Tony Lindgren To: Ben Hutchings Cc: Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] gpio: omap: Enable software fallback for long debounce periods Message-ID: References: <20210811202751.GB18930@cephalopod> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811202751.GB18930@cephalopod> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org * Ben Hutchings [210811 20:28]: > omap2_set_gpio_debounce() currently returns -EINVAL if the debounce > period is too long to be handled in hardware. gpiolib provides a > software fallback, but it is used only if the driver returns > -ENOTSUPP. > > * Enable the software fallback by using the expected error code > * Downgrade the log message about this from info to debug, since > the error is now handled Looks good to me: Reviewed-by: Tony Lindgren