From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Subbaraman Narayanamurthy <quic_subbaram@quicinc.com>
Cc: Andy Gross <agross@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: qcom: spmi-gpio: add support to enable/disable output
Date: Tue, 21 Sep 2021 16:53:21 -0500 [thread overview]
Message-ID: <YUpUUdx9UJ+aL0Fu@builder.lan> (raw)
In-Reply-To: <1631588246-4811-3-git-send-email-quic_subbaram@quicinc.com>
On Mon 13 Sep 21:57 CDT 2021, Subbaraman Narayanamurthy wrote:
> Currently, if the GPIO is configured as output in the bootloader
> and user changes the mode to input in HLOS, it would end up
> getting configured as input/output. Functionally, this is fine;
> however, there may be some requirements where the output needs
> to be disabled so that it can be used only for input.
>
> Add support to enable/disable output mode through "output-enable"
> or "output-disable" pinctrl properties.
>
> Signed-off-by: Subbaraman Narayanamurthy <quic_subbaram@quicinc.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 98bf0e2..39a18aa 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (c) 2012-2014, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2012-2014, 2021, The Linux Foundation. All rights reserved.
> */
>
> #include <linux/gpio/driver.h>
> @@ -424,6 +424,9 @@ static int pmic_gpio_config_get(struct pinctrl_dev *pctldev,
> return -EINVAL;
> arg = 1;
> break;
> + case PIN_CONFIG_OUTPUT_ENABLE:
> + arg = pad->output_enabled;
> + break;
> case PIN_CONFIG_OUTPUT:
> arg = pad->out_value;
> break;
> @@ -503,6 +506,9 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
> case PIN_CONFIG_INPUT_ENABLE:
> pad->input_enabled = arg ? true : false;
> break;
> + case PIN_CONFIG_OUTPUT_ENABLE:
> + pad->output_enabled = arg ? true : false;
> + break;
> case PIN_CONFIG_OUTPUT:
> pad->output_enabled = true;
> pad->out_value = arg;
> --
> 2.7.4
>
prev parent reply other threads:[~2021-09-21 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 2:57 [PATCH 0/2] pinctrl: qcom: spmi-gpio: Add support to enable/disable output Subbaraman Narayanamurthy
2021-09-14 2:57 ` [PATCH 1/2] dt-bindings: pinctrl: qcom-pmic-gpio: Add output-{enable,disable} properties Subbaraman Narayanamurthy
2021-09-21 20:23 ` Rob Herring
2021-09-23 21:34 ` Linus Walleij
2021-09-14 2:57 ` [PATCH 2/2] pinctrl: qcom: spmi-gpio: add support to enable/disable output Subbaraman Narayanamurthy
2021-09-21 21:53 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUpUUdx9UJ+aL0Fu@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).