From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add QCM2290 pinctrl bindings
Date: Tue, 21 Sep 2021 16:59:24 -0500 [thread overview]
Message-ID: <YUpVvB3zNMaiV78I@builder.lan> (raw)
In-Reply-To: <20210914074542.12957-2-shawn.guo@linaro.org>
On Tue 14 Sep 02:45 CDT 2021, Shawn Guo wrote:
> Add device tree bindings for QCM2290 pinctrl.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> .../pinctrl/qcom,qcm2290-pinctrl.yaml | 186 ++++++++++++++++++
> 1 file changed, 186 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml
>
[..]
> +'$defs':
> + qcom-qcm2290-tlmm-state:
> + type: object
> + description:
> + Pinctrl node's client devices use subnodes for desired pin configuration.
> + Client device subnodes use below standard properties.
> + $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
> +
> + properties:
> + pins:
> + description:
> + List of gpio pins affected by the properties specified in this
> + subnode.
> + items:
> + oneOf:
> + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$"
^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-6])$
To make it cover the entire gpio space.
The rest looks good!
Regards,
Bjorn
next prev parent reply other threads:[~2021-09-21 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 7:45 [PATCH 0/2] Add pinctrl driver for QCM2290 Shawn Guo
2021-09-14 7:45 ` [PATCH 1/2] dt-bindings: pinctrl: qcom: Add QCM2290 pinctrl bindings Shawn Guo
2021-09-21 20:24 ` Rob Herring
2021-09-21 21:59 ` Bjorn Andersson [this message]
2021-09-14 7:45 ` [PATCH 2/2] pinctrl: qcom: Add QCM2290 pinctrl driver Shawn Guo
2021-09-21 21:57 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUpVvB3zNMaiV78I@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).