From: Joerie de Gram <j.de.gram@gmail.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] pinctrl: amd: Fix wakeups when IRQ is shared with SCI
Date: Sat, 16 Oct 2021 01:53:56 +0200 [thread overview]
Message-ID: <YWoUlGFMWAXTvMuR@p14s> (raw)
In-Reply-To: <20211015144332.700-1-mario.limonciello@amd.com>
On Fri, Oct 15, 2021 at 09:43:32AM -0500, Mario Limonciello wrote:
> + if (irq < 0 && !(regval & BIT(WAKE_STS_OFF)))
> + return true;
Shouldn't be negated. WAKE_STS_OFF is set on wakeup.
With that change:
Reported-by: Joerie de Gram <j.de.gram@gmail.com>
Tested-by: Joerie de Gram <j.de.gram@gmail.com>
next prev parent reply other threads:[~2021-10-15 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 14:43 [PATCH] pinctrl: amd: Fix wakeups when IRQ is shared with SCI Mario Limonciello
2021-10-15 23:53 ` Joerie de Gram [this message]
[not found] ` <CAHp75Vfx0uyOgP7q7cs=VNaZC1_hWkdMy8VFw_MpXbaYJxSmFQ@mail.gmail.com>
2021-10-18 21:10 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWoUlGFMWAXTvMuR@p14s \
--to=j.de.gram@gmail.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).