From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
vladimir.zapolskiy@linaro.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets
Date: Tue, 9 Nov 2021 12:42:24 +0530 [thread overview]
Message-ID: <YYofWOH0V6uYBJYJ@matsya> (raw)
In-Reply-To: <20211104170835.1993686-1-bjorn.andersson@linaro.org>
On 04-11-21, 10:08, Bjorn Andersson wrote:
> The downstream TLMM binding covers a group of TLMM-related hardware
> blocks, but the upstream binding only captures the particular block
> related to controlling the TLMM pins from an OS. In the translation of
> the driver from downstream, the offset of 0x100000 was lost for the UFS
> and SDC pingroups.
>
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> index 4d8f8636c2b3..1c042d39380c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sm8350.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sm8350.c
> @@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
> [200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
> [201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
> [202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
> - [203] = UFS_RESET(ufs_reset, 0x1d8000),
> - [204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
> - [205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
> - [206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
> + [203] = UFS_RESET(ufs_reset, 0xd8000),
> + [204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
> + [205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
> + [206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
Right, these are the offsets defined in the the documentation, sorry to
have missed updating here
Reviewed-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
next prev parent reply other threads:[~2021-11-09 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 17:08 [PATCH] pinctrl: qcom: sm8350: Correct UFS and SDC offsets Bjorn Andersson
2021-11-06 17:08 ` Vladimir Zapolskiy
2021-11-09 7:12 ` Vinod Koul [this message]
2021-11-09 20:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYofWOH0V6uYBJYJ@matsya \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox