From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A75C433EF for ; Tue, 9 Nov 2021 10:34:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BBFE6115B for ; Tue, 9 Nov 2021 10:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241794AbhKIKhk (ORCPT ); Tue, 9 Nov 2021 05:37:40 -0500 Received: from mga05.intel.com ([192.55.52.43]:45631 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241716AbhKIKhj (ORCPT ); Tue, 9 Nov 2021 05:37:39 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="318619662" X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="318619662" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 02:34:46 -0800 X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="451867922" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 02:34:42 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mkOST-0053Br-MD; Tue, 09 Nov 2021 12:34:29 +0200 Date: Tue, 9 Nov 2021 12:34:29 +0200 From: Andy Shevchenko To: Arnd Bergmann Cc: linux-gpio@vger.kernel.org, Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/8] gpiolib: split linux/gpio/driver.h out of linux/gpio.h Message-ID: References: <20211109100207.2474024-1-arnd@kernel.org> <20211109100207.2474024-9-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211109100207.2474024-9-arnd@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Nov 09, 2021 at 11:02:07AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Almost all gpio drivers include linux/gpio/driver.h, and other > files should not rely on includes from this header. > > Remove the indirect include from here and include the correct > headers directly from where they are used. Reviewed-by: Andy Shevchenko for gpio.h changes with one comment below. > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-omap1/irq.c | 1 + > arch/arm/mach-orion5x/board-rd88f5182.c | 1 + > arch/arm/mach-pxa/lubbock.c | 2 +- > arch/arm/mach-s3c/mach-h1940.c | 1 + > arch/arm/mach-s3c/s3c64xx.c | 1 + > arch/arm/mach-sa1100/assabet.c | 1 + > arch/arm/plat-orion/gpio.c | 1 + > drivers/gpio/gpio-ucb1400.c | 1 + > drivers/mfd/dm355evm_msp.c | 1 + > drivers/mfd/htc-i2cpld.c | 1 + > drivers/mfd/ucb1400_core.c | 1 + > drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c | 1 + > include/linux/bcma/bcma_driver_chipcommon.h | 2 +- > include/linux/gpio.h | 3 --- > include/linux/mfd/ucb1x00.h | 1 + > include/linux/ucb1400.h | 1 + > 16 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-omap1/irq.c b/arch/arm/mach-omap1/irq.c > index ee6a93083154..d8c38270867f 100644 > --- a/arch/arm/mach-omap1/irq.c > +++ b/arch/arm/mach-omap1/irq.c > @@ -41,6 +41,7 @@ > #include > #include > #include > +#include > > #include > #include > diff --git a/arch/arm/mach-orion5x/board-rd88f5182.c b/arch/arm/mach-orion5x/board-rd88f5182.c > index b7b0f52f4c0a..99abf6daca77 100644 > --- a/arch/arm/mach-orion5x/board-rd88f5182.c > +++ b/arch/arm/mach-orion5x/board-rd88f5182.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm/mach-pxa/lubbock.c b/arch/arm/mach-pxa/lubbock.c > index 742d18a1f7dc..875b405d9fce 100644 > --- a/arch/arm/mach-pxa/lubbock.c > +++ b/arch/arm/mach-pxa/lubbock.c > @@ -9,7 +9,7 @@ > * Copyright: MontaVista Software Inc. > */ > #include > -#include > +#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c/mach-h1940.c b/arch/arm/mach-s3c/mach-h1940.c > index 8a43ed1c4c4d..0cc9f9d08c38 100644 > --- a/arch/arm/mach-s3c/mach-h1940.c > +++ b/arch/arm/mach-s3c/mach-h1940.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm/mach-s3c/s3c64xx.c b/arch/arm/mach-s3c/s3c64xx.c > index 4dfb648142f2..d098e28bd5dd 100644 > --- a/arch/arm/mach-s3c/s3c64xx.c > +++ b/arch/arm/mach-s3c/s3c64xx.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm/mach-sa1100/assabet.c b/arch/arm/mach-sa1100/assabet.c > index 9919e0f32c4b..4ba2d28c1fd3 100644 > --- a/arch/arm/mach-sa1100/assabet.c > +++ b/arch/arm/mach-sa1100/assabet.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c > index 734f0be4f14a..e21d589ec78a 100644 > --- a/arch/arm/plat-orion/gpio.c > +++ b/arch/arm/plat-orion/gpio.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/gpio/gpio-ucb1400.c b/drivers/gpio/gpio-ucb1400.c > index d2a8644864c3..aceac8bb12ff 100644 > --- a/drivers/gpio/gpio-ucb1400.c > +++ b/drivers/gpio/gpio-ucb1400.c > @@ -6,6 +6,7 @@ > */ > > #include > +#include > #include > > static int ucb1400_gpio_dir_in(struct gpio_chip *gc, unsigned off) > diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c > index 2388fb4d0121..2c82907600f0 100644 > --- a/drivers/mfd/dm355evm_msp.c > +++ b/drivers/mfd/dm355evm_msp.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c > index 417b0355d904..d7d0a2e50746 100644 > --- a/drivers/mfd/htc-i2cpld.c > +++ b/drivers/mfd/htc-i2cpld.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > > diff --git a/drivers/mfd/ucb1400_core.c b/drivers/mfd/ucb1400_core.c > index 8c3832a58ef6..f71ef41ac9dc 100644 > --- a/drivers/mfd/ucb1400_core.c > +++ b/drivers/mfd/ucb1400_core.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > > unsigned int ucb1400_adc_read(struct snd_ac97 *ac97, u16 adc_channel, > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c > index c1b9ac692d26..2349fcce37dd 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > #include > #include > +#include > #include > #include > #include > diff --git a/include/linux/bcma/bcma_driver_chipcommon.h b/include/linux/bcma/bcma_driver_chipcommon.h > index d35b9206096d..9ba1b6311681 100644 > --- a/include/linux/bcma/bcma_driver_chipcommon.h > +++ b/include/linux/bcma/bcma_driver_chipcommon.h > @@ -3,7 +3,7 @@ > #define LINUX_BCMA_DRIVER_CC_H_ > > #include > -#include > +#include > > /** ChipCommon core registers. **/ > #define BCMA_CC_ID 0x0000 > diff --git a/include/linux/gpio.h b/include/linux/gpio.h > index 61fb427b4e70..f25546e060e9 100644 > --- a/include/linux/gpio.h > +++ b/include/linux/gpio.h > @@ -54,9 +54,6 @@ struct gpio { > }; > > #ifdef CONFIG_GPIOLIB > - > -#include > -#include > #include Hmm... It's in some of the previous patches I suppose. Do we really need this to be under ifdeffery? > > /* Platforms may implement their GPIO interface with library code, > diff --git a/include/linux/mfd/ucb1x00.h b/include/linux/mfd/ucb1x00.h > index 43bcf35afe27..7c0d40ddc674 100644 > --- a/include/linux/mfd/ucb1x00.h > +++ b/include/linux/mfd/ucb1x00.h > @@ -9,6 +9,7 @@ > > #include > #include > +#include > #include > #include > > diff --git a/include/linux/ucb1400.h b/include/linux/ucb1400.h > index 0968ef458447..199b1280fa26 100644 > --- a/include/linux/ucb1400.h > +++ b/include/linux/ucb1400.h > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > #include > > /* > -- > 2.29.2 > -- With Best Regards, Andy Shevchenko