From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E97C433EF for ; Tue, 9 Nov 2021 12:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DBC66115A for ; Tue, 9 Nov 2021 12:07:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236479AbhKIMKb (ORCPT ); Tue, 9 Nov 2021 07:10:31 -0500 Received: from mga01.intel.com ([192.55.52.88]:62495 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237666AbhKIMKb (ORCPT ); Tue, 9 Nov 2021 07:10:31 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="256113349" X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="256113349" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 04:05:07 -0800 X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="588658106" Received: from smile.fi.intel.com ([10.237.72.184]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 04:05:03 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mkPru-0054hE-NF; Tue, 09 Nov 2021 14:04:50 +0200 Date: Tue, 9 Nov 2021 14:04:50 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Bartosz Golaszewski , Jianqun Xu , Sai Krishna Potthuri , Andrew Morton , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bamvor Jian Zhang , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Heiko Stuebner , Patrice Chotard , Michal Simek , Andy Shevchenko Subject: Re: [PATCH v1 13/19] pinctrl: st: Drop wrong kernel doc annotations Message-ID: References: <20211105124242.27288-1-andriy.shevchenko@linux.intel.com> <20211105124242.27288-13-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Nov 09, 2021 at 12:32:31PM +0100, Linus Walleij wrote: > On Fri, Nov 5, 2021 at 1:43 PM Andy Shevchenko > wrote: > > > Kernel doc validator is not happy: > > > > .../pinctrl-st.c:59: warning: This comment starts with '/**', but isn't a kernel-doc comment. > > .../pinctrl-st.c:73: warning: This comment starts with '/**', but isn't a kernel-doc comment. > > > > Drop them as they are indeed not a kernel doc comments. > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Linus Walleij > > Hm maybe I could just apply this patch, shouldn't collide with anything. > Let me know your preference. You may apply whatever patches you want that are precursors for the strarray() idea. Basically you may apply somewhat 9 patches if I'm not mistaken. Of course if you have no objections. -- With Best Regards, Andy Shevchenko