* Re: [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
2021-11-22 22:36 Ed Schaller
@ 2021-11-22 17:51 ` Andy Shevchenko
2021-11-23 9:12 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2021-11-22 17:51 UTC (permalink / raw)
To: Ed Schaller; +Cc: Lee Jones, linux-gpio
On Mon, Nov 22, 2021 at 04:36:06PM -0600, Ed Schaller wrote:
> Add new IDs of the Intel Lakefield chip to the list of supported
> devices.
Thank you for the patch, it LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Ed Schaller <schallee@darkmist.net>
> ---
> drivers/mfd/intel-lpss-pci.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index a872b4485eac..9700e5acd0cd 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -359,7 +359,14 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> /* LKF */
> { PCI_VDEVICE(INTEL, 0x98a8), (kernel_ulong_t)&bxt_uart_info },
> { PCI_VDEVICE(INTEL, 0x98a9), (kernel_ulong_t)&bxt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x98aa), (kernel_ulong_t)&bxt_info },
> + { PCI_VDEVICE(INTEL, 0x98c5), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x98c6), (kernel_ulong_t)&bxt_i2c_info },
> { PCI_VDEVICE(INTEL, 0x98c7), (kernel_ulong_t)&bxt_uart_info },
> + { PCI_VDEVICE(INTEL, 0x98e8), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x98e9), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x98ea), (kernel_ulong_t)&bxt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0x98eb), (kernel_ulong_t)&bxt_i2c_info },
> /* SPT-LP */
> { PCI_VDEVICE(INTEL, 0x9d27), (kernel_ulong_t)&spt_uart_info },
> { PCI_VDEVICE(INTEL, 0x9d28), (kernel_ulong_t)&spt_uart_info },
> --
> 2.30.2
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
@ 2021-11-22 22:36 Ed Schaller
2021-11-22 17:51 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Ed Schaller @ 2021-11-22 22:36 UTC (permalink / raw)
To: Lee Jones, linux-gpio
Add new IDs of the Intel Lakefield chip to the list of supported
devices.
Signed-off-by: Ed Schaller <schallee@darkmist.net>
---
drivers/mfd/intel-lpss-pci.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index a872b4485eac..9700e5acd0cd 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -359,7 +359,14 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
/* LKF */
{ PCI_VDEVICE(INTEL, 0x98a8), (kernel_ulong_t)&bxt_uart_info },
{ PCI_VDEVICE(INTEL, 0x98a9), (kernel_ulong_t)&bxt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x98aa), (kernel_ulong_t)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0x98c5), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x98c6), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x98c7), (kernel_ulong_t)&bxt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x98e8), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x98e9), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x98ea), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x98eb), (kernel_ulong_t)&bxt_i2c_info },
/* SPT-LP */
{ PCI_VDEVICE(INTEL, 0x9d27), (kernel_ulong_t)&spt_uart_info },
{ PCI_VDEVICE(INTEL, 0x9d28), (kernel_ulong_t)&spt_uart_info },
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
2021-11-22 17:51 ` Andy Shevchenko
@ 2021-11-23 9:12 ` Lee Jones
2021-11-23 9:38 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2021-11-23 9:12 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Ed Schaller, linux-gpio
On Mon, 22 Nov 2021, Andy Shevchenko wrote:
> On Mon, Nov 22, 2021 at 04:36:06PM -0600, Ed Schaller wrote:
> > Add new IDs of the Intel Lakefield chip to the list of supported
> > devices.
>
> Thank you for the patch, it LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> > Signed-off-by: Ed Schaller <schallee@darkmist.net>
> > ---
> > drivers/mfd/intel-lpss-pci.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> > index a872b4485eac..9700e5acd0cd 100644
> > --- a/drivers/mfd/intel-lpss-pci.c
> > +++ b/drivers/mfd/intel-lpss-pci.c
> > @@ -359,7 +359,14 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> > /* LKF */
> > { PCI_VDEVICE(INTEL, 0x98a8), (kernel_ulong_t)&bxt_uart_info },
> > { PCI_VDEVICE(INTEL, 0x98a9), (kernel_ulong_t)&bxt_uart_info },
> > + { PCI_VDEVICE(INTEL, 0x98aa), (kernel_ulong_t)&bxt_info },
> > + { PCI_VDEVICE(INTEL, 0x98c5), (kernel_ulong_t)&bxt_i2c_info },
> > + { PCI_VDEVICE(INTEL, 0x98c6), (kernel_ulong_t)&bxt_i2c_info },
> > { PCI_VDEVICE(INTEL, 0x98c7), (kernel_ulong_t)&bxt_uart_info },
> > + { PCI_VDEVICE(INTEL, 0x98e8), (kernel_ulong_t)&bxt_i2c_info },
> > + { PCI_VDEVICE(INTEL, 0x98e9), (kernel_ulong_t)&bxt_i2c_info },
> > + { PCI_VDEVICE(INTEL, 0x98ea), (kernel_ulong_t)&bxt_i2c_info },
> > + { PCI_VDEVICE(INTEL, 0x98eb), (kernel_ulong_t)&bxt_i2c_info },
> > /* SPT-LP */
> > { PCI_VDEVICE(INTEL, 0x9d27), (kernel_ulong_t)&spt_uart_info },
> > { PCI_VDEVICE(INTEL, 0x9d28), (kernel_ulong_t)&spt_uart_info },
Odd. This didn't make it into my inbox.
Would you mind gathering Andy's R-b and re-sending please Ed?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
2021-11-23 9:12 ` Lee Jones
@ 2021-11-23 9:38 ` Andy Shevchenko
2021-11-23 10:12 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2021-11-23 9:38 UTC (permalink / raw)
To: Lee Jones; +Cc: Ed Schaller, linux-gpio
On Tue, Nov 23, 2021 at 09:12:42AM +0000, Lee Jones wrote:
> On Mon, 22 Nov 2021, Andy Shevchenko wrote:
> > On Mon, Nov 22, 2021 at 04:36:06PM -0600, Ed Schaller wrote:
> > > Add new IDs of the Intel Lakefield chip to the list of supported
> > > devices.
> >
> > Thank you for the patch, it LGTM,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> Odd. This didn't make it into my inbox.
Hmm... Maybe it's sorted out due to linux-gpio@ vs. linux-kernel@ ML?
> Would you mind gathering Andy's R-b and re-sending please Ed?
Ed, please Cc also to LKML.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
2021-11-23 9:38 ` Andy Shevchenko
@ 2021-11-23 10:12 ` Lee Jones
2021-11-23 10:22 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Lee Jones @ 2021-11-23 10:12 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Ed Schaller, linux-gpio
On Tue, 23 Nov 2021, Andy Shevchenko wrote:
> On Tue, Nov 23, 2021 at 09:12:42AM +0000, Lee Jones wrote:
> > On Mon, 22 Nov 2021, Andy Shevchenko wrote:
> > > On Mon, Nov 22, 2021 at 04:36:06PM -0600, Ed Schaller wrote:
> > > > Add new IDs of the Intel Lakefield chip to the list of supported
> > > > devices.
> > >
> > > Thank you for the patch, it LGTM,
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> ...
>
> > Odd. This didn't make it into my inbox.
>
> Hmm... Maybe it's sorted out due to linux-gpio@ vs. linux-kernel@ ML?
No, I mean it doesn't appear anywhere in my mail.
Including LKML et al. sub-folders.
> > Would you mind gathering Andy's R-b and re-sending please Ed?
>
> Ed, please Cc also to LKML.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
2021-11-23 10:12 ` Lee Jones
@ 2021-11-23 10:22 ` Andy Shevchenko
[not found] ` <CAJo6XL_DfWcVbT92X8fsd=mvs9AkzNQ2A1hPJpeGxrqC3BuL=g@mail.gmail.com>
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2021-11-23 10:22 UTC (permalink / raw)
To: Lee Jones; +Cc: Ed Schaller, linux-gpio
On Tue, Nov 23, 2021 at 10:12:41AM +0000, Lee Jones wrote:
> On Tue, 23 Nov 2021, Andy Shevchenko wrote:
> > On Tue, Nov 23, 2021 at 09:12:42AM +0000, Lee Jones wrote:
> > > On Mon, 22 Nov 2021, Andy Shevchenko wrote:
...
> > > Odd. This didn't make it into my inbox.
> >
> > Hmm... Maybe it's sorted out due to linux-gpio@ vs. linux-kernel@ ML?
>
> No, I mean it doesn't appear anywhere in my mail.
>
> Including LKML et al. sub-folders.
I see, this is indeed odd.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
[not found] ` <CAJo6XL_DfWcVbT92X8fsd=mvs9AkzNQ2A1hPJpeGxrqC3BuL=g@mail.gmail.com>
@ 2021-11-23 14:04 ` Lee Jones
0 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-11-23 14:04 UTC (permalink / raw)
To: Ed Schaller; +Cc: Andy Shevchenko, Ed Schaller, linux-gpio
On Tue, 23 Nov 2021, Ed Schaller wrote:
> On Tue, Nov 23, 2021 at 3:22 AM Andy Shevchenko <andriy.shevchenko@intel.com>
> wrote:
>
> > On Tue, Nov 23, 2021 at 10:12:41AM +0000, Lee Jones wrote:
> > > On Tue, 23 Nov 2021, Andy Shevchenko wrote:
> > > > On Tue, Nov 23, 2021 at 09:12:42AM +0000, Lee Jones wrote:
> > > > > On Mon, 22 Nov 2021, Andy Shevchenko wrote:
> >
> > ...
> >
> > > > > Odd. This didn't make it into my inbox.
> > > >
> > > > Hmm... Maybe it's sorted out due to linux-gpio@ vs. linux-kernel@ ML?
> > >
> > > No, I mean it doesn't appear anywhere in my mail.
> > >
> > > Including LKML et al. sub-folders.
> >
> > I see, this is indeed odd.
>
> I submitted again with Andy's RB.
>
> I'd suspect spam filters given the issues I've had with that domain before.
Ah yes, that would make sense. Thanks for resubmitting.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
@ 2021-11-23 18:01 Ed Schaller
2021-11-24 8:31 ` Lee Jones
0 siblings, 1 reply; 9+ messages in thread
From: Ed Schaller @ 2021-11-23 18:01 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-gpio
Add new IDs of the Intel Lakefield chip to the list of supported
devices.
Signed-off-by: Ed Schaller <schallee@darkmist.net>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
drivers/mfd/intel-lpss-pci.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index a872b4485eac..9700e5acd0cd 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -359,7 +359,14 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
/* LKF */
{ PCI_VDEVICE(INTEL, 0x98a8), (kernel_ulong_t)&bxt_uart_info },
{ PCI_VDEVICE(INTEL, 0x98a9), (kernel_ulong_t)&bxt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x98aa), (kernel_ulong_t)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0x98c5), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x98c6), (kernel_ulong_t)&bxt_i2c_info },
{ PCI_VDEVICE(INTEL, 0x98c7), (kernel_ulong_t)&bxt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x98e8), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x98e9), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x98ea), (kernel_ulong_t)&bxt_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x98eb), (kernel_ulong_t)&bxt_i2c_info },
/* SPT-LP */
{ PCI_VDEVICE(INTEL, 0x9d27), (kernel_ulong_t)&spt_uart_info },
{ PCI_VDEVICE(INTEL, 0x9d28), (kernel_ulong_t)&spt_uart_info },
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs
2021-11-23 18:01 [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs Ed Schaller
@ 2021-11-24 8:31 ` Lee Jones
0 siblings, 0 replies; 9+ messages in thread
From: Lee Jones @ 2021-11-24 8:31 UTC (permalink / raw)
To: Ed Schaller; +Cc: linux-gpio
On Tue, 23 Nov 2021, Ed Schaller wrote:
> Add new IDs of the Intel Lakefield chip to the list of supported
> devices.
>
> Signed-off-by: Ed Schaller <schallee@darkmist.net>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> ---
> drivers/mfd/intel-lpss-pci.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-11-24 8:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-23 18:01 [PATCH] mfd: intel-lpss: Add Intel Lakefield PCH PCI IDs Ed Schaller
2021-11-24 8:31 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2021-11-22 22:36 Ed Schaller
2021-11-22 17:51 ` Andy Shevchenko
2021-11-23 9:12 ` Lee Jones
2021-11-23 9:38 ` Andy Shevchenko
2021-11-23 10:12 ` Lee Jones
2021-11-23 10:22 ` Andy Shevchenko
[not found] ` <CAJo6XL_DfWcVbT92X8fsd=mvs9AkzNQ2A1hPJpeGxrqC3BuL=g@mail.gmail.com>
2021-11-23 14:04 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).