From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yuchang Hsu <saraon640529@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
Richard_Hsu@asmedia.com.tw, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Yd_Tseng@asmedia.com.tw,
Cindy1_Hsu@asmedia.com.tw, Andrew_Su@asmedia.com.tw
Subject: Re: [PATCH v2] gpio:amdpt:add new device ID and 24-pin support
Date: Wed, 8 Dec 2021 14:19:47 +0200 [thread overview]
Message-ID: <YbCi4zv8247Jgfhe@smile.fi.intel.com> (raw)
In-Reply-To: <20211208103621.9253-1-Richard_Hsu@asmedia.com.tw>
On Wed, Dec 08, 2021 at 06:36:21PM +0800, Yuchang Hsu wrote:
Thanks for update, my comments below.
> Hi Andy Shevchenko,
> How and what to put the Changelog after '---'?i just remove '---'.
No, you shouldn't remove it, instead you should add the text after it in a free
form of what you have done in the submitted version in comparison to the
previous one.
To achieve this use `git format-patch ...` and then edit it and then send it
with a help of `git send-email ...`.
> This patch adds a ACPI HID(AMDIF031) and pin number in the pt_gpio_acpi_match.
"This patch adds a ..." --> "Add an ..."
> And We retrieve pin number supporting by device_get_match_data().
"And " --> ""
"supporting " --> ""
So, waiting for v3.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-12-08 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 10:36 [PATCH v2] gpio:amdpt:add new device ID and 24-pin support Yuchang Hsu
2021-12-08 12:19 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbCi4zv8247Jgfhe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Andrew_Su@asmedia.com.tw \
--cc=Cindy1_Hsu@asmedia.com.tw \
--cc=Richard_Hsu@asmedia.com.tw \
--cc=Yd_Tseng@asmedia.com.tw \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saraon640529@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).