From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shuah Khan <shuah@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH -next] selftests: gpio: gpio-sim: remove bashisms
Date: Mon, 13 Dec 2021 18:38:37 +0200 [thread overview]
Message-ID: <Ybd3DT5e3fCP5JiS@smile.fi.intel.com> (raw)
In-Reply-To: <20211213162625.18081-1-brgl@bgdev.pl>
On Mon, Dec 13, 2021 at 05:26:25PM +0100, Bartosz Golaszewski wrote:
> '==' is a bashisms and not understood by POSIX shell. Drop it from
> gpio-sim selftests.
> - if [ "$BANK" == "live" ] || [ "$BANK" == "dev_name" ]; then
> + if [ "$BANK" = "live" ] || [ "$BANK" = "dev_name" ]; then
While at it, no need to fork `test` twice, isn't it?
if [ "$BANK" = "live" -o "$BANK" = "dev_name" ]; then
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-13 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 16:26 [PATCH -next] selftests: gpio: gpio-sim: remove bashisms Bartosz Golaszewski
2021-12-13 16:38 ` Andy Shevchenko [this message]
2021-12-13 18:30 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybd3DT5e3fCP5JiS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).