linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mfd: cirrus,lochnagar: fix pin controller nodename
@ 2021-12-07  8:36 Rafał Miłecki
  2021-12-07 10:03 ` Charles Keepax
  2021-12-13 23:15 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Rafał Miłecki @ 2021-12-07  8:36 UTC (permalink / raw)
  To: Lee Jones
  Cc: Rob Herring, Charles Keepax, Richard Fitzgerald, linux-gpio,
	devicetree, linux-kernel, patches, Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

Replace custom nodename with a generic "pinctrl" to match new pinctrl
binding requirement. This will fix:
Documentation/devicetree/bindings/mfd/cirrus,lochnagar.example.dt.yaml: lochnagar-pinctrl: $nodename:0: 'lochnagar-pinctrl' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
        From schema: Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml

Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml b/Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
index c00ad3e21c21..ad285cb480c9 100644
--- a/Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
+++ b/Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
@@ -126,7 +126,7 @@ properties:
       clock-frequency:
         const: 12288000
 
-  lochnagar-pinctrl:
+  pinctrl:
     type: object
     $ref: /schemas/pinctrl/cirrus,lochnagar.yaml#
 
@@ -255,7 +255,7 @@ required:
   - reg
   - reset-gpios
   - lochnagar-clk
-  - lochnagar-pinctrl
+  - pinctrl
 
 additionalProperties: false
 
@@ -293,7 +293,7 @@ examples:
                 clock-frequency = <32768>;
             };
 
-            lochnagar-pinctrl {
+            pinctrl {
                 compatible = "cirrus,lochnagar-pinctrl";
 
                 gpio-controller;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: mfd: cirrus,lochnagar: fix pin controller nodename
  2021-12-07  8:36 [PATCH] dt-bindings: mfd: cirrus,lochnagar: fix pin controller nodename Rafał Miłecki
@ 2021-12-07 10:03 ` Charles Keepax
  2021-12-13 23:15 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2021-12-07 10:03 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Lee Jones, Rob Herring, Richard Fitzgerald, linux-gpio,
	devicetree, linux-kernel, patches, Rafał Miłecki

On Tue, Dec 07, 2021 at 09:36:18AM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Replace custom nodename with a generic "pinctrl" to match new pinctrl
> binding requirement. This will fix:
> Documentation/devicetree/bindings/mfd/cirrus,lochnagar.example.dt.yaml: lochnagar-pinctrl: $nodename:0: 'lochnagar-pinctrl' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
>         From schema: Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml
> 
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> 

Thanks,
Charles

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: mfd: cirrus,lochnagar: fix pin controller nodename
  2021-12-07  8:36 [PATCH] dt-bindings: mfd: cirrus,lochnagar: fix pin controller nodename Rafał Miłecki
  2021-12-07 10:03 ` Charles Keepax
@ 2021-12-13 23:15 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-13 23:15 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Lee Jones, Rob Herring, linux-gpio, linux-kernel, Charles Keepax,
	Rafał Miłecki, devicetree, patches, Richard Fitzgerald

On Tue, 07 Dec 2021 09:36:18 +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Replace custom nodename with a generic "pinctrl" to match new pinctrl
> binding requirement. This will fix:
> Documentation/devicetree/bindings/mfd/cirrus,lochnagar.example.dt.yaml: lochnagar-pinctrl: $nodename:0: 'lochnagar-pinctrl' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
>         From schema: Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml
> 
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-13 23:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-07  8:36 [PATCH] dt-bindings: mfd: cirrus,lochnagar: fix pin controller nodename Rafał Miłecki
2021-12-07 10:03 ` Charles Keepax
2021-12-13 23:15 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).