From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jon Hunter <jonathanh@nvidia.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: tegra: Convert to json-schema
Date: Tue, 21 Dec 2021 15:10:57 +0100 [thread overview]
Message-ID: <YcHgcbUNZfmGFZ3j@orome> (raw)
In-Reply-To: <YcHbzrUNDaqjTNtN@robh.at.kernel.org>
[-- Attachment #1: Type: text/plain, Size: 3794 bytes --]
On Tue, Dec 21, 2021 at 09:51:10AM -0400, Rob Herring wrote:
> On Fri, Dec 17, 2021 at 05:53:42PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Convert the NVIDIA Tegra pinmux controller bindings from the free-form
> > text format to json-schema.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > .../pinctrl/nvidia,tegra114-pinmux.txt | 131 --------
> > .../pinctrl/nvidia,tegra114-pinmux.yaml | 264 ++++++++++++++++
> > .../pinctrl/nvidia,tegra124-pinmux.txt | 153 ----------
> > .../pinctrl/nvidia,tegra124-pinmux.yaml | 287 ++++++++++++++++++
> > .../pinctrl/nvidia,tegra194-pinmux.txt | 107 -------
> > .../pinctrl/nvidia,tegra194-pinmux.yaml | 175 +++++++++++
> > .../pinctrl/nvidia,tegra20-pinmux.txt | 143 ---------
> > .../pinctrl/nvidia,tegra20-pinmux.yaml | 203 +++++++++++++
> > .../pinctrl/nvidia,tegra210-pinmux.txt | 166 ----------
> > .../pinctrl/nvidia,tegra210-pinmux.yaml | 232 ++++++++++++++
> > .../pinctrl/nvidia,tegra30-pinmux.txt | 144 ---------
> > .../pinctrl/nvidia,tegra30-pinmux.yaml | 268 ++++++++++++++++
> > 12 files changed, 1429 insertions(+), 844 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.txt
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml
> > delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.txt
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.yaml
> > delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.txt
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra194-pinmux.yaml
> > delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.txt
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra20-pinmux.yaml
> > delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.txt
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra210-pinmux.yaml
> > delete mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.txt
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra30-pinmux.yaml
>
>
> > diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml
> > new file mode 100644
> > index 000000000000..fa95d0bd6fe4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra114-pinmux.yaml
> > @@ -0,0 +1,264 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
>
> GPL-2.0-only please.
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pinctrl/nvidia,tegra114-pinmux.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NVIDIA Tegra114 pinmux Controller
> > +
> > +maintainers:
> > + - Thierry Reding <thierry.reding@gmail.com>
> > + - Jon Hunter <jonathanh@nvidia.com>
> > +
> > +properties:
> > + compatible:
> > + const: nvidia,tegra114-pinmux
> > +
> > + reg:
> > + items:
> > + - description: pad control registers
> > + - description: mux registers
> > +
> > +additionalProperties:
> > + type: object
>
> additionalProperties: false
>
> That will cause the example to fail.
The idea here was for additionalProperties: to match anything that was
not elsewhere specified and as such to serve as a catch-all for the
pinmux subnodes. That way I wouldn't have to come up with a pattern to
match all existing uses.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-12-21 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 16:53 [PATCH] dt-bindings: pinctrl: tegra: Convert to json-schema Thierry Reding
2021-12-17 22:25 ` Rob Herring
2021-12-21 13:51 ` Rob Herring
2021-12-21 14:10 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcHgcbUNZfmGFZ3j@orome \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).