From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: linux-gpio@vger.kernel.org, kernel test robot <lkp@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS
Date: Thu, 17 Mar 2022 12:47:43 +0100 [thread overview]
Message-ID: <YjMf3xraXv5In6vP@latitude> (raw)
In-Reply-To: <20220317114413.1418484-1-j.neuschaefer@gmx.net>
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Thu, Mar 17, 2022 at 12:44:12PM +0100, Jonathan Neuschäfer wrote:
> CONFIG_GENERIC_PINCTRL_GROUPS must be selected in order for
> struct group_desc to be defined in pinctrl/core.h.
>
> Add the missing select line to CONFIG_PINCTRL_WPCM450.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Ah well, I forgot
Fixes: a1d1e0e3d80a8 ("pinctrl: nuvoton: Add driver for WPCM450")
which would be appropriate here.
> ---
> drivers/pinctrl/nuvoton/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
> index 6a3c6f2a73f2d..b48d32912bef1 100644
> --- a/drivers/pinctrl/nuvoton/Kconfig
> +++ b/drivers/pinctrl/nuvoton/Kconfig
> @@ -6,6 +6,7 @@ config PINCTRL_WPCM450
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> + select GENERIC_PINCTRL_GROUPS
> select GPIOLIB
> select GPIO_GENERIC
> select GPIOLIB_IRQCHIP
> --
> 2.35.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-17 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 11:44 [PATCH] pinctrl: nuvoton: wpcm450: select GENERIC_PINCTRL_GROUPS Jonathan Neuschäfer
2022-03-17 11:47 ` Jonathan Neuschäfer [this message]
2022-03-24 0:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjMf3xraXv5In6vP@latitude \
--to=j.neuschaefer@gmx.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).