From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Bill Wendling <morbo@google.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Nathan Chancellor <nathan@kernel.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] gpiolib: acpi: use correct format characters
Date: Fri, 18 Mar 2022 16:03:38 +0200 [thread overview]
Message-ID: <YjSROmYwwGhpsXMl@smile.fi.intel.com> (raw)
In-Reply-To: <CAKwvOdkjb3uR+kqjfdKL5gqA8R+00c5=3E7uGGW+mGZ3QRsjqg@mail.gmail.com>
On Thu, Mar 17, 2022 at 11:11:21AM -0700, Nick Desaulniers wrote:
> On Thu, Mar 17, 2022 at 2:07 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Mar 16, 2022 at 02:30:55PM -0700, Bill Wendling wrote:
> > NAK.
I hope you read my follow up to this.
> Andy,
> Our goal is to enable -Wformat for CC=clang. Please see also:
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]")
Not that I agree on that commit for %h[h]x
signed char ch = -1;
printf("%x\n", ch);
printf("%hhx\n", ch);
That's why my first reaction on this change was NAK.
> and the lore link it cites.
> https://lore.kernel.org/lkml/CAHk-=wgoxnmsj8GEVFJSvTwdnWm8wVJthefNk2n6+4TC=20e0Q@mail.gmail.com/
> (I saw your follow up; this patch is one of the less controversial
> ones though since the types are not ones that are promoted).
That said, I hope you are very well aware of the case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-18 14:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 21:30 [PATCH] gpiolib: acpi: use correct format characters Bill Wendling
2022-03-17 9:06 ` Andy Shevchenko
2022-03-17 9:12 ` Andy Shevchenko
2022-03-17 18:11 ` Nick Desaulniers
2022-03-18 14:03 ` Andy Shevchenko [this message]
2022-03-18 18:01 ` Nick Desaulniers
2022-03-18 18:25 ` Bill Wendling
2022-03-18 18:29 ` Nick Desaulniers
2022-03-18 18:33 ` Bill Wendling
2022-03-18 18:40 ` Linus Torvalds
2022-03-18 18:46 ` Bill Wendling
2022-03-18 18:31 ` Linus Torvalds
2022-03-19 22:22 ` [PATCH v2] " Bill Wendling
2022-03-19 22:54 ` Linus Torvalds
2022-03-19 23:21 ` Linus Torvalds
2022-03-21 10:07 ` Andy Shevchenko
2022-03-21 17:05 ` Linus Torvalds
2022-03-21 18:04 ` Bill Wendling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjSROmYwwGhpsXMl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).