Re: [PATCH] pinctrl: nuvoton: Fix sparse warning

["Jonathan Neuschäfer" <j.neuschaefer@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

On Wed, Mar 23, 2022 at 12:16:04AM +0100, Linus Walleij wrote:
> Sparse complains:
> drivers/pinctrl/nuvoton/pinctrl-wpcm450.c:626:9:
> sparse: sparse: obsolete array initializer, use C99 syntax
> 
> This is because no equal sign is between the array index
> and the assignments, in the macro.
> 
> Fix it up.
> 
> Cc: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---

Sounds good to me, thanks!

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>


>  drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> index 661aa963e3fc..1402840af11f 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> @@ -613,8 +613,8 @@ static struct wpcm450_func wpcm450_funcs[] = {
>  };
>  
>  #define WPCM450_PINCFG(a, b, c, d, e, f, g) \
> -	[a] { .fn0 = fn_ ## b, .reg0 = WPCM450_GCR_ ## c, .bit0 = d, \
> -	      .fn1 = fn_ ## e, .reg1 = WPCM450_GCR_ ## f, .bit1 = g }
> +	[a] = { .fn0 = fn_ ## b, .reg0 = WPCM450_GCR_ ## c, .bit0 = d, \
> +	        .fn1 = fn_ ## e, .reg1 = WPCM450_GCR_ ## f, .bit1 = g }

You will find the same in the pinctrl-npcm7xx driver:

 #define NPCM7XX_PINCFG(a, b, c, d, e, f, g, h, i, j, k) \
        [a] { .fn0 = fn_ ## b, .reg0 = NPCM7XX_GCR_ ## c, .bit0 = d, /*...*/  }



Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]