From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linus.walleij@linaro.org, robh+dt@kernel.org,
catalin.marinas@arm.com, will@kernel.org,
gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
kostap@marvell.com, robert.marko@sartura.hr,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] pinctrl: mvebu: pinctrl driver for 98DX2530 SoC
Date: Wed, 6 Apr 2022 14:36:30 +0200 [thread overview]
Message-ID: <Yk2JTo91sZHunEpN@lunn.ch> (raw)
In-Reply-To: <20220406032158.1449049-3-chris.packham@alliedtelesis.co.nz>
On Wed, Apr 06, 2022 at 03:21:56PM +1200, Chris Packham wrote:
> This pinctrl driver supports the 98DX25xx and 98DX35xx family of chips
> from Marvell. It is based on the Marvell SDK with additions for various
> (non-gpio) pin configurations based on the datasheet.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
>
> Notes:
> Changes in v3:
> - Use mmio instead of syscon
Hi Chris
syscon is used when the register space is shared with other
devices. Is that not the case here? You can share mmio spaces, but you
have to use the correct call to reserve it, so that the system knows
it is to be shared. Or are all the pinctl registers contiguous and you
are only reserve just the registers you need, leaving other drivers
fee to take what they need?
I'm just trying to ensure you are not going to have trouble later when
you add other drivers.
Andrew
next prev parent reply other threads:[~2022-04-06 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 3:21 [PATCH v3 0/4] arm64: mvebu: Support for Marvell 98DX2530 (and variants) Chris Packham
2022-04-06 3:21 ` [PATCH v3 1/4] dt-bindings: pinctrl: mvebu: Document bindings for AC5 Chris Packham
2022-04-06 23:20 ` Andrew Lunn
2022-04-13 18:29 ` Rob Herring
2022-04-06 3:21 ` [PATCH v3 2/4] pinctrl: mvebu: pinctrl driver for 98DX2530 SoC Chris Packham
2022-04-06 12:36 ` Andrew Lunn [this message]
2022-04-06 21:51 ` Chris Packham
2022-04-06 23:17 ` Andrew Lunn
2022-04-06 3:21 ` [PATCH v3 3/4] arm64: dts: marvell: Add Armada 98DX2530 SoC and RD-AC5X board Chris Packham
2022-04-06 23:23 ` Andrew Lunn
2022-04-06 23:29 ` Chris Packham
2022-04-06 3:21 ` [PATCH v3 4/4] arm64: marvell: enable the 98DX2530 pinctrl driver Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk2JTo91sZHunEpN@lunn.ch \
--to=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kostap@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).