linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Luca Weiss <luca@z3ntu.xyz>, David Heidelberg <david@ixit.cz>,
	Konrad Dybcio <konrad.dybcio@somainline.org>
Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges'
Date: Mon, 16 May 2022 08:11:12 -0700	[thread overview]
Message-ID: <YoJpkG6vqXf7HFcN@ripper> (raw)
In-Reply-To: <20220508135932.132378-2-krzysztof.kozlowski@linaro.org>

On Sun 08 May 06:59 PDT 2022, Krzysztof Kozlowski wrote:

> 'gpio-reserved-ranges' property is already used and supported by common pinctrl
> bindings, so add it also here to fix warnings like:
> 
>   qrb5165-rb5.dtb: gpio@c000: 'gpio-reserved-ranges' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
>  .../bindings/pinctrl/qcom,pmic-gpio.yaml      | 53 +++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 7e74a87ccc39..69195660ee2a 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -78,6 +78,12 @@ properties:
>      minItems: 2
>      maxItems: 44
>  
> +  gpio-reserved-ranges:
> +    minItems: 1
> +    # maxItems as half of total number of GPIOs, as there has to be at
> +    # least one usable GPIO between each reserved range.
> +    maxItems: 22
> +
>    '#gpio-cells':
>      const: 2
>      description:
> @@ -107,6 +113,8 @@ allOf:
>          gpio-line-names:
>            minItems: 2
>            maxItems: 2
> +        gpio-reserved-ranges:
> +          maxItems: 1
>  
>    - if:
>        properties:
> @@ -124,6 +132,9 @@ allOf:
>          gpio-line-names:
>            minItems: 4
>            maxItems: 4
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 2
>  
>    - if:
>        properties:
> @@ -137,6 +148,9 @@ allOf:
>          gpio-line-names:
>            minItems: 6
>            maxItems: 6
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 3
>  
>    - if:
>        properties:
> @@ -150,6 +164,9 @@ allOf:
>          gpio-line-names:
>            minItems: 8
>            maxItems: 8
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 4
>  
>    - if:
>        properties:
> @@ -163,6 +180,9 @@ allOf:
>          gpio-line-names:
>            minItems: 9
>            maxItems: 9
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 5
>  
>    - if:
>        properties:
> @@ -182,6 +202,9 @@ allOf:
>          gpio-line-names:
>            minItems: 10
>            maxItems: 10
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 5
>  
>    - if:
>        properties:
> @@ -194,6 +217,9 @@ allOf:
>          gpio-line-names:
>            minItems: 11
>            maxItems: 11
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 6
>  
>    - if:
>        properties:
> @@ -212,6 +238,9 @@ allOf:
>          gpio-line-names:
>            minItems: 12
>            maxItems: 12
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 6
>  
>    - if:
>        properties:
> @@ -224,6 +253,9 @@ allOf:
>          gpio-line-names:
>            minItems: 13
>            maxItems: 13
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 7
>  
>    - if:
>        properties:
> @@ -236,6 +268,9 @@ allOf:
>          gpio-line-names:
>            minItems: 14
>            maxItems: 14
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 7
>  
>    - if:
>        properties:
> @@ -248,6 +283,9 @@ allOf:
>          gpio-line-names:
>            minItems: 16
>            maxItems: 16
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 8
>  
>    - if:
>        properties:
> @@ -261,6 +299,9 @@ allOf:
>          gpio-line-names:
>            minItems: 22
>            maxItems: 22
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 11
>  
>    - if:
>        properties:
> @@ -273,6 +314,9 @@ allOf:
>          gpio-line-names:
>            minItems: 26
>            maxItems: 26
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 13
>  
>    - if:
>        properties:
> @@ -285,6 +329,9 @@ allOf:
>          gpio-line-names:
>            minItems: 36
>            maxItems: 36
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 18
>  
>    - if:
>        properties:
> @@ -297,6 +344,9 @@ allOf:
>          gpio-line-names:
>            minItems: 38
>            maxItems: 38
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 19
>  
>    - if:
>        properties:
> @@ -310,6 +360,9 @@ allOf:
>          gpio-line-names:
>            minItems: 44
>            maxItems: 44
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 22
>  
>  patternProperties:
>    '-state$':
> -- 
> 2.32.0
> 

  parent reply	other threads:[~2022-05-16 15:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08 13:59 [PATCH 0/4] dt-bindings/pinctrl/arm: qcom: second round of minor cleanups of QCOM PMIC pinctrl Krzysztof Kozlowski
2022-05-08 13:59 ` [PATCH 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges' Krzysztof Kozlowski
2022-05-10 16:52   ` Rob Herring
2022-05-13 23:18   ` Linus Walleij
2022-05-14 19:42     ` Krzysztof Kozlowski
2022-05-16 15:11   ` Bjorn Andersson [this message]
2022-05-08 13:59 ` [PATCH 2/4] arm64: dts: qcom: add missing gpio-ranges in PMIC GPIOs Krzysztof Kozlowski
2022-05-08 13:59 ` [RFT 3/4] arm64: dts: qcom: correct interrupt controller on PM8916 and PMS405 Krzysztof Kozlowski
2022-05-08 13:59 ` [PATCH 4/4] ARM: dts: qcom: add missing gpio-ranges in PMIC GPIOs Krzysztof Kozlowski
2022-06-28 20:19   ` (subset) " Bjorn Andersson
2022-05-19 13:02 ` [PATCH 0/4] dt-bindings/pinctrl/arm: qcom: second round of minor cleanups of QCOM PMIC pinctrl Linus Walleij
2022-06-28 20:19 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoJpkG6vqXf7HFcN@ripper \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).