From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E09C433F5 for ; Tue, 24 May 2022 12:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237350AbiEXMeW (ORCPT ); Tue, 24 May 2022 08:34:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237341AbiEXMeV (ORCPT ); Tue, 24 May 2022 08:34:21 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E14695A2A for ; Tue, 24 May 2022 05:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653395660; x=1684931660; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=slZnXl+rBUnCmhi6d+tFf8jJ5+WznZjZdHxCtZQ3E9U=; b=U2RK9EtQpBIxHTuGltSWBptxuAUIVFmWIpkm/DupBDgftKV7e4k5c3CM rCAqbu/P2xvY6ZQ+LGY+xEDL6fZRMacTXTiY5FOH7O6QpIGwzO4d8yR/b OEXzpVk7TWJOBOLcxdN0Z74sSZbRflO5ZF3eufHQZFR5HUCRu822Veh7f VYWBJSSQ9ZuWyKi6J54dHC4BI1Uar3gYWD1If9ygGhT8vtvMKlqZ9Cywu MsxAMh+cX5oVP3tohA9AgUv2YwHkl/fsAKEsrpSSD07BkL6L5NdhPqe09 nV8K2IGDGvu1KYiIyu8KLos1kVHL7DWthUVvXscOSjK9sTDwYueHLC8UA g==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="261124256" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="261124256" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 05:34:19 -0700 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="548455366" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.162]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 05:34:17 -0700 Received: by lahna (sSMTP sendmail emulation); Tue, 24 May 2022 15:34:14 +0300 Date: Tue, 24 May 2022 15:34:14 +0300 From: Mika Westerberg To: Basavaraj Natikar Cc: Andy Shevchenko , Shyam-sundar.S-k@amd.com, linux-gpio@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v2 2/3] pinctrl: amd: Get and update IOMUX details Message-ID: References: <20220524074007.2792445-1-Basavaraj.Natikar@amd.com> <20220524074007.2792445-3-Basavaraj.Natikar@amd.com> <8ba8857d-c3ab-8959-5bc3-a4e225459f61@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, May 24, 2022 at 05:54:47PM +0530, Basavaraj Natikar wrote: > There is no CRS method defined for IOMX/0xFED80D00 in ACPI namespace // IOMX Address Base > Hence I added additional code to get IOMX memory region. > > since _CRS method is used to get GPIO pin base for AMDI0030 in > pinctrl-amd as below, same is not available for IOMX > > Device (GPIO) > { > Name (_HID, "AMDI0030") // _HID: Hardware ID > Name (_CID, "AMDI0030") // _CID: Compatible ID > Name (_UID, Zero) // _UID: Unique ID > Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings > { > Name (RBUF, ResourceTemplate () > { > Interrupt (ResourceConsumer, Level, ActiveLow, Shared, ,, ) > { > 0x00000007, > } > Memory32Fixed (ReadWrite, > 0xFED81500, // Address Base > 0x00000400, // Address Length > ) Is there something preventing you to add it here like below? Memory32Fixed (ReadWrite, 0xFED80D00 0x00000400)