From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/1] gpio: wcove: make irq_chip immutable
Date: Wed, 1 Jun 2022 19:48:24 +0300 [thread overview]
Message-ID: <YpeYWKpD+ls2DMm5@smile.fi.intel.com> (raw)
In-Reply-To: <YpePLa0jbTLusGU9@smile.fi.intel.com>
On Wed, Jun 01, 2022 at 07:09:17PM +0300, Andy Shevchenko wrote:
> On Wed, Jun 01, 2022 at 08:51:03AM -0700, Sathyanarayanan Kuppuswamy wrote:
> > On 6/1/22 8:48 AM, Andy Shevchenko wrote:
> > > Since recently, the kernel is nagging about mutable irq_chips:
> > >
> > > "not an immutable chip, please consider fixing it!"
> > >
> > > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new
> > > helper functions and call the appropriate gpiolib functions.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > Looks good to me
> >
> > Reviewed-by: Kuppuswamy Sathyanarayanan
> > <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Thanks!
>
> Please fix your tools so it won't split tag line and `b4` may automatically test it.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-06-01 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 15:48 [PATCH v1 1/1] gpio: wcove: make irq_chip immutable Andy Shevchenko
2022-06-01 15:51 ` Sathyanarayanan Kuppuswamy
2022-06-01 16:09 ` Andy Shevchenko
2022-06-01 16:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpeYWKpD+ls2DMm5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).