From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F115FC433EF for ; Wed, 1 Jun 2022 16:48:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351656AbiFAQsb (ORCPT ); Wed, 1 Jun 2022 12:48:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234144AbiFAQsa (ORCPT ); Wed, 1 Jun 2022 12:48:30 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFE96A2042; Wed, 1 Jun 2022 09:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654102109; x=1685638109; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=00iMzNpl4nVdOEC1GABzCwR9itIjYCdYxTEgVqgNnCQ=; b=KiWN7X+eNAX667k1LzNMCNthvwcQDqb6TPduY+FzmHlSZQ0fUPXtmC9w g6tfo7QvDNJq6+13MH8pOj4GpRI/dw+kxLwyZiRF1ylE+yXUBCoOt5fXk 2MeBCRg37R/zz0rcRZfn0pZ/hXKjRsIylgSY7iI5tGvLZfUjwve7clyJH RjynBwZdaF7Uc1+ULHZHbZKAJcmH6Aez18zglHkLZfLAEbT0lodwsg5LA 8+znuN3gCZAUMCIDLpMsRMWdc4WJDKlQrEAQXgTGr+79AHK6Jn4nVzl46 SBpil7QvFY+EKvK/ethE2ampdIKMaC/5V6XJeMRYQmpRf+O2uCb8l0xu6 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10365"; a="338698165" X-IronPort-AV: E=Sophos;i="5.91,268,1647327600"; d="scan'208";a="338698165" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2022 09:48:29 -0700 X-IronPort-AV: E=Sophos;i="5.91,268,1647327600"; d="scan'208";a="756351737" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2022 09:48:27 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nwRWC-000QqK-Kt; Wed, 01 Jun 2022 19:48:24 +0300 Date: Wed, 1 Jun 2022 19:48:24 +0300 From: Andy Shevchenko To: Sathyanarayanan Kuppuswamy Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Subject: Re: [PATCH v1 1/1] gpio: wcove: make irq_chip immutable Message-ID: References: <20220601154833.2173-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Jun 01, 2022 at 07:09:17PM +0300, Andy Shevchenko wrote: > On Wed, Jun 01, 2022 at 08:51:03AM -0700, Sathyanarayanan Kuppuswamy wrote: > > On 6/1/22 8:48 AM, Andy Shevchenko wrote: > > > Since recently, the kernel is nagging about mutable irq_chips: > > > > > > "not an immutable chip, please consider fixing it!" > > > > > > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new > > > helper functions and call the appropriate gpiolib functions. > > > > > > Signed-off-by: Andy Shevchenko > > > > Looks good to me > > > > Reviewed-by: Kuppuswamy Sathyanarayanan > > > > Thanks! > > Please fix your tools so it won't split tag line and `b4` may automatically test it. Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko