From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E698CCA47B for ; Mon, 13 Jun 2022 09:44:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239912AbiFMJou (ORCPT ); Mon, 13 Jun 2022 05:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239981AbiFMJot (ORCPT ); Mon, 13 Jun 2022 05:44:49 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39A8B18B37; Mon, 13 Jun 2022 02:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1655113483; bh=JV08/kjmQgd4Qe/JyQ5XWzd1+ENzu/6aRjVgufY/viA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=LtmAWDnr6zYw+r4RHApWEQM1jdjbDBPbkIHdoJ1c4PXyTf5hKUH9aF6M44pXtWdbM sRWari1IWHC3oSKNsTB7GB6iegjFyGl83abNCisPWTmip8fTz5DRcSGY9Ox3NWpDf2 QhQjEGdV/M1xxp/DFqTt/GkN13EAzfmZQDfHJgGc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([5.146.195.3]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mj8qd-1nUfCI3Twj-00fBb4; Mon, 13 Jun 2022 11:44:43 +0200 Date: Mon, 13 Jun 2022 11:44:42 +0200 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Andy Shevchenko Cc: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , "open list:GPIO SUBSYSTEM" , Linus Walleij , OpenBMC Maillist , Linux Kernel Mailing List Subject: Re: [PATCH v2] pinctrl: nuvoton: wpcm450: Convert irqchip to IRQCHIP_IMMUTABLE Message-ID: References: <20220610001609.276220-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nFuUPyBHrWNRC1jf" Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:ganESRDkMTNhY/3vfP34bJRGjKRv1dXv6gfWQaz9IJ1+21uuv+Y Xd70/lMlnvkj1BupWk0HgtU7Q/kNhcaiQ88+dJ/GJbJFbUvGrliLPkXn5Y61mVepEMARZNs ZKuGwKTrQ/oOwRKhm02CnZdEJnW+gHhiq9ufzZa9qI3xQASwNO6OFx59r50xxi95Mx0qz13 HnkNDfa1CcYqnS9ZNuKrw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Y5stFMT5I88=:TidO2uItKM8jjIkwI9u6Ar BkBb+Gn4HmfTqh+85Q0T0O1trkKnvhW23Cph9ih9O8yX28DJxM7jd9F9YGe/vadGjd0NI0aux pLQbw92zSNWwtxIbiSjF0oH4ImwPNLc4CQ9fWDVg0PyTsNlgSJxFNsZqY4cNOVse8uH52CAQX Lznt6MTl3qCx8/NQt7lE/A1ebkgfKc0YWm0yKfttmBlb/s6AFmYiCzt29xn5o7wSKoP4p/3tV SVmM5zfALbtEdSl90Gfx6r+Oh5tDwafY05oCnT9QLeotKKNEYcFHkFFtKXZuMSPOhvMCTjQse YdkO7ShTtBXyBRTviKGG0EHmjaBL2MGf0pVt+IK2cnYiNo5Ocq0zoOxuyoEErkzG9c67Z9k78 UfFuAntsvtArdAo0AyWXSJkIhh0L47jZZ2dWIruVuBj07E2Ryw3XrzTaAR4152jqHM0l87ItW ur2hcBRhYbXKDzI95qi2nRMhcgjxb37f2Pv3GxdhWrau/gaiYO9nrtkUgsv2BqqhVQaaDkn0r oAmZPS77b2ebGV6finM7JN3kAS5OXvekttvPMf0HFfX75k1EPhIHhNEOVWxf8jTF2FaA5Rchp IddQCa9FHG3PEhvO9GXrM1mWVYLddjV4ZUcwAOznBNnSqKxIL8bRtW1fnVnz3jNIJe0bRz3GJ gGk29vQwESKkqsjOlzyKpjIB3IviIqXsanf56/yYnSgNiF302PNPPA44//nN0qedY0d1DrHUJ FHaYpZ0GuZMBokXFnuIRP+4l/zE8mLV9VUh6O1FFX9LCKIF7V9DwL2yAay2/6Gq3k2gZanmgI nMKcxpjedG63YkWAJ54QA3aKPCkm93+AeLBtEV6dU/pkBKco2QNQ4DoT0SoY+MpCa0MBjgTBI HfzKTNs9v7qtDEGkvS7kL7SWv5AoHxgQnWHgotiEXu8t2i5LOFogwSFQEl30KiZnDp4gbCb7l 4l3TnXsVRe0awusfDmcGfQJ9UoFiwKXggq6Owcl+5Va/kCbj4Svr1xBXJTmvWtl99DsexrMjy sveMmkOEvggiNVOoGpN1ZaHZhkjcJtIGo0oxNcsZecIOpsTGOOtDaIJvHqjygGvyyv44Id//D gK1gzAbOqCdoKbufPy3tGW/NkCuqRrrkBNxoJWm1X0C/sbZPMJRIiiXGQ== Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --nFuUPyBHrWNRC1jf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 10, 2022 at 02:07:55PM +0200, Andy Shevchenko wrote: > On Fri, Jun 10, 2022 at 2:24 AM Jonathan Neusch=C3=A4fer > wrote: > > > > Commit 6c846d026d490 ("gpio: Don't fiddle with irqchips marked as > > immutable") added a warning for irqchips that are not marked with > > IRQCHIP_IMMUTABLE. > > > > Convert the pinctrl-wpcm450 driver to an immutable irqchip. >=20 > ... >=20 > > + gpiochip_disable_irq(gc, d->hwirq); >=20 > > + gpiochip_enable_irq(gc, d->hwirq); >=20 > Can you use the helper (*) as stated in the documentation? >=20 > *) irqd_to_hwirq(d) Ah, oops. I'll fix it. Thanks, Jonathan --nFuUPyBHrWNRC1jf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmKnBukACgkQCDBEmo7z X9vOiw//dDj/H/znJVravzUdFFJgpBmzBRjArecl9dEDhZj+Cgw7HXPNn2G0MgBh +RqDSwTl+gtMn1n+a8sCt4m+O7inm4I29Za1AzaKTEfoG3Iw01QpCrHoFEyhpcpV oeNoyTDBaj72D2XJmlgC5oMwFql5jtnOCh2gJ77Uoi7synnH4822GoleNj27zCpf 98Ch1TbqRWygSATj93FUHH0kPSLdWwYO1kaCofq80YwAOG+NkjBqzTEawdsb4CqI DLc1Zu4sptwe6NrrqIgj1/iD4oTjc0oYUnH4R2QY8pRF1LBS5y/3yLF3EByqww5z vY7Rv0j5qwM6yjYGb9mD3Ig7nhKk8/fGk/1y0QNsti21Gnz6wY6Wz9smfig/6X51 7fIYUrRBrVG6b9nxGuhXev5/P5s/VxkD87RpBHqXKGdJf9PMMt8EviYwy1Ys4oHT NucOrKLS3ErEiNG63xTiwEMYflaVvpJz15PJ4hLZHrHeUx3bV5MqHeV0F/c69rKf NVWyD4zuhCU3u98Pbfvrdlhz83rfEWmNdC60PQ4Qwg1MF5yQR0B8ZjmKjCXvC1yU Id6Svok5zN+WdrYag+aYyri7F52ny/YEAYLDBJISzHDxy4471HSlIF8pTIdHJeVn YrPTuNChRzjXRTTq67Kl+1SmuwYUyMM3q9Ej8JtQWYp4mPRgOTI= =I1MA -----END PGP SIGNATURE----- --nFuUPyBHrWNRC1jf--