From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE8EAC433EF for ; Thu, 23 Jun 2022 09:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230526AbiFWJym (ORCPT ); Thu, 23 Jun 2022 05:54:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbiFWJyl (ORCPT ); Thu, 23 Jun 2022 05:54:41 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D806D2B27E; Thu, 23 Jun 2022 02:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655978080; x=1687514080; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=s9GG/sY6wixWx6Kt3EOgPjnu6ifIHWLBKr6/jZ+J2kc=; b=IITV4DWRuYjDMX+DzJYsiSTcYCDNqm2xHBdymjGRcv/DW/n/dgKOGnHx DUnrO3nAFsN96lba2guO0wGPJruWZ9aj7fDkLWj6kXDA/xadvSpW+hDeE 4qb/3h+7eoZIbl/HnJXDHW0mnuWt/kJIG5XGeaDnEXYg0RXpcCG45hKgZ UkJo9LD/oyESJXFE8z/hZD3bql3348j152X3nYQH5ZYYcWY0ScVoaq5Kd egAWPCQ8Wnf3VaFB0CwKeY4rNSelZXlI5PQLGXcuO8ZaDtwWk3cwaIKSJ fpWRuBu+Pn/D4GZ74OagS6fxk0IVtMT2Iaz9QFnAcUr9L2sqXp+Emh+Od g==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="306136383" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="306136383" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 02:54:40 -0700 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="563387365" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 02:54:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1o4JXn-000t1W-Hf; Thu, 23 Jun 2022 12:54:35 +0300 Date: Thu, 23 Jun 2022 12:54:35 +0300 From: Andy Shevchenko To: Dan Carpenter Cc: Linus Walleij , "Maciej S. Szmigiero" , Bartosz Golaszewski , linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] gpio: winbond: Fix error code in winbond_gpio_get() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Jun 23, 2022 at 11:29:48AM +0300, Dan Carpenter wrote: > This error path returns 1, but it should instead propagate the negative > error code from winbond_sio_enter(). Reviewed-by: Andy Shevchenko > Fixes: a0d65009411c ("gpio: winbond: Add driver") > Signed-off-by: Dan Carpenter > --- > drivers/gpio/gpio-winbond.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-winbond.c b/drivers/gpio/gpio-winbond.c > index 7f8f5b02e31d..4b61d975cc0e 100644 > --- a/drivers/gpio/gpio-winbond.c > +++ b/drivers/gpio/gpio-winbond.c > @@ -385,12 +385,13 @@ static int winbond_gpio_get(struct gpio_chip *gc, unsigned int offset) > unsigned long *base = gpiochip_get_data(gc); > const struct winbond_gpio_info *info; > bool val; > + int ret; > > winbond_gpio_get_info(&offset, &info); > > - val = winbond_sio_enter(*base); > - if (val) > - return val; > + ret = winbond_sio_enter(*base); > + if (ret) > + return ret; > > winbond_sio_select_logical(*base, info->dev); > > -- > 2.35.1 > -- With Best Regards, Andy Shevchenko