From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F446CCA47C for ; Wed, 13 Jul 2022 17:39:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236517AbiGMRjv (ORCPT ); Wed, 13 Jul 2022 13:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236470AbiGMRjr (ORCPT ); Wed, 13 Jul 2022 13:39:47 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F652CDDE; Wed, 13 Jul 2022 10:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657733986; x=1689269986; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=gSo9n+h/0n7VMQiSc66NjBQwHdhMPYnAit+C0irfWRk=; b=nu1iN2V6aigRBY3Z0TMAIO50y3OwrIUfgJOsYuWCby3OoJMeqU/CyM8l +EgBJ3FwxoP3iB8Ljy80YhATmXQ81ajwjmWEuldglYQBvnMxBuZJ0G90q xP8/axci8TIqpbwoe+gMP2aBXABKmZmpJgXtdSR767HA0/q+pS/1zN75O OBFm0a2BGXCUMfoR+pP3tJQ2j27MWsVrQIP8/gMXTK1RdyvlcHbtbaiTs H6/sGHPciY9QfdqRUwhlUScRYts5cvfjN7HawYj5bBEFKnh5vGX6xvnop UauEhQh7D48y86OEKalDv0Qpo1p8naVgwRAJXyQeg7f+jbfmRmAmTK2cJ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="282849828" X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="282849828" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 10:39:14 -0700 X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="570728793" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 10:39:11 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oBgKK-001CZP-1u; Wed, 13 Jul 2022 20:39:08 +0300 Date: Wed, 13 Jul 2022 20:39:08 +0300 From: Andy Shevchenko To: Nuno =?iso-8859-1?Q?S=E1?= Cc: linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Krzysztof Kozlowski , Bartosz Golaszewski , Frank Rowand , Mika Westerberg , Rob Herring , Linus Walleij Subject: Re: [PATCH 0/4] add support for bias pull-disable Message-ID: References: <20220713131421.1527179-1-nuno.sa@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220713131421.1527179-1-nuno.sa@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Jul 13, 2022 at 03:14:17PM +0200, Nuno Sá wrote: > The gpio core looks at 'FLAG_BIAS_DISABLE' in preparation of calling the > gpiochip 'set_config()' hook. However, AFAICT, there's no way that this > flag is set because there's no support for it in firwmare code. Moreover, > in 'gpiod_configure_flags()', only pull-ups and pull-downs are being > handled. Isn't it enough? > On top of this, there are some users that are looking at > 'PIN_CONFIG_BIAS_DISABLE' in the 'set_config()' hook. So, unless I'm > missing something, it looks like this was never working for these chips. It seems you are looking into wrong source of issues. Isn't it a issue of particular pin control driver? > Note that the ACPI case is only compiled tested. At first glance, it seems > the current patch is enough but i'm not really sure... > > As a side note, this came to my attention during this patchset [1] > (and, ofr OF, was tested with it). -- With Best Regards, Andy Shevchenko