From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jon Hunter <jonathanh@nvidia.com>,
Prathamesh Shete <pshete@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: tegra: Convert to json-schema
Date: Mon, 4 Jul 2022 19:10:09 +0200 [thread overview]
Message-ID: <YsMe8ZGuHv50Bumw@orome> (raw)
In-Reply-To: <20220701211708.GA1523809-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]
On Fri, Jul 01, 2022 at 03:17:08PM -0600, Rob Herring wrote:
> On Fri, Jul 01, 2022 at 05:04:58PM +0200, Thierry Reding wrote:
[...]
> > +additionalProperties:
> > + description: |
> > + Tegra's pin configuration nodes act as containers for an arbitrary number of subnodes. Each of
> > + these subnodes represents some desired configuration for a pin, a group, or a list of pins or
> > + groups. This configuration can include the mux function to select on those pin(s)/group(s), and
> > + various pin configuration parameters, such as pull-up, tristate, drive strength, etc.
> > +
> > + The name of each subnode is not important; all subnodes should be enumerated and processed
> > + purely based on their content.
> > +
> > + Each subnode only affects those parameters that are explicitly listed. In other words, a
> > + subnode that lists a mux function but no pin configuration parameters implies no information
> > + about any pin configuration parameters. Similarly, a pin subnode that describes a pullup
> > + parameter implies no information about e.g. the mux function or tristate parameter. For this
> > + reason, even seemingly boolean values are actually tristates in this binding: unspecified, off,
> > + or on. Unspecified is represented as an absent property, and off/on are represented as integer
> > + values 0 and 1.
> > +
> > + See the TRM to determine which properties and values apply to each pin/group. Macro values for
> > + property values are defined in include/dt-binding/pinctrl/pinctrl-tegra.h.
> > + type: object
> > + patternProperties:
> > + "^pinmux(-[a-z0-9-_]+)?$":
>
> type: object
Looks like this fell through the cracks. I've fixed in in v3 locally,
but I'll hold off on resending the whole series to avoid the churn.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-04 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 15:04 [PATCH 0/4] pinctrl: tegra: Separate Tegra194 instances Thierry Reding
2022-07-01 15:04 ` [PATCH 1/4] dt-bindings: pinctrl: tegra: Convert to json-schema Thierry Reding
2022-07-01 21:17 ` Rob Herring
2022-07-04 17:01 ` Thierry Reding
2022-07-04 17:10 ` Thierry Reding [this message]
2022-07-01 15:04 ` [PATCH 2/4] dt-bindings: pinctrl: tegra194: Separate instances Thierry Reding
2022-07-01 21:19 ` Rob Herring
2022-07-04 17:02 ` Thierry Reding
2022-07-01 15:05 ` [PATCH 3/4] pinctrl: tegra: Separate Tegra194 instances Thierry Reding
2022-07-01 15:05 ` [PATCH 4/4] arm64: tegra: Separate AON pinmux from main pinmux on Tegra194 Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsMe8ZGuHv50Bumw@orome \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=robh@kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).