From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6737C433EF for ; Tue, 12 Jul 2022 03:07:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230453AbiGLDHL (ORCPT ); Mon, 11 Jul 2022 23:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231877AbiGLDGn (ORCPT ); Mon, 11 Jul 2022 23:06:43 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B7BF33A18 for ; Mon, 11 Jul 2022 20:06:42 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id b25so4864512qkl.1 for ; Mon, 11 Jul 2022 20:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AOfzzS/NAq/eRmLGRpw95xaiIHsu/LwIwpnwcG9ELxU=; b=UINuF0a1aRcsNC6pElpGLcfasWKxHi7dvgXrpT26/5mMqb2z+XY0DwpYkmpG/InjOe dNwYb6lZ3ZssTJI2Yt7jkUkzE7/4BmTSQmJwq6aV4ZF57eXWvtB1ucLQo/8PiRxY9X3R yFUSdiEQSjT9YZGWvFCr2b4BQKf+byu+blakhZq128t/nTtCrvErMkVFNVj/yX9+B1wT pnnuwG7f0+YBM9pBLG3n0XV4vXjtydocRFmU1Z27YuTpm5JNgOd4yIA3258CjNL3CLBu kn7uNu/w3eS/ElUuNN9RN83wx2Vbbk5bnYmt6wwnshw+fGd0JmtPl0JjcfuPAL6++BeY f0cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AOfzzS/NAq/eRmLGRpw95xaiIHsu/LwIwpnwcG9ELxU=; b=M3edbnLxE+Iz7KwR+AwR4LwyYzaihKkutzh9v/uOozmg1ezn/jw+0z+qJUkwIavDCI PK/SpGuSHNCx1mgQ/z1OQfQLuso34rLRGQ28DuuTP4V03WvrfVmIp487PaedfO7wZwV4 cHFUz9BTtScd0iOejm3eKYDDfhk0AmSpLrb1wplZi/5qq/mQG/xZcyIXLcDLCS5WDo9S 1+QE1H7c3I8gSHJaFY1iKevFnhYLLDT0hXy0xusua9IRN3d8z+FRDXeY7Gh4uNjN/Pkb AYQWQLPmykh0hIM1CSaEFgjpkfGkM9jkpYJDg4V5USt/fQAChTLxF6n41M8xNoltsvB1 INXA== X-Gm-Message-State: AJIora+oPGBMq8fHFj1laHod9GBhTWM/rSYDgYg0+j0qLOZJm0X82CEl 5lPlSLseU2ezeHUqqRoDyKzirQ== X-Google-Smtp-Source: AGRyM1vJ/aNhWX/Az5F7+pr4yZOi+nHAKaRaeGJKkClK6+nT9OyU9sdlqt/nE+bEM5AAmyoDMd/SRA== X-Received: by 2002:a37:9fd2:0:b0:6b5:7642:5ee0 with SMTP id i201-20020a379fd2000000b006b576425ee0mr8854420qke.452.1657595201307; Mon, 11 Jul 2022 20:06:41 -0700 (PDT) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id fp6-20020a05622a508600b0031eb0bb5c3csm5144501qtb.28.2022.07.11.20.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 20:06:40 -0700 (PDT) Date: Mon, 11 Jul 2022 23:06:39 -0400 From: William Breathitt Gray To: Linus Walleij Cc: brgl@bgdev.pl, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Fred Eckert , John Hentges , Jay Dolan Subject: Re: [PATCH v2 1/6] gpio: i8255: Introduce the i8255 module Message-ID: References: <6be749842a4ad629c8697101f170dc7e425ae082.1657216200.git.william.gray@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fPnMJIDMmtvaXDMm" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --fPnMJIDMmtvaXDMm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 11, 2022 at 03:02:10PM +0200, Linus Walleij wrote: > On Fri, Jul 8, 2022 at 1:16 AM William Breathitt Gray > wrote: >=20 > > Exposes consumer functions providing support for Intel 8255 Programmable > > Peripheral Interface devices. A CONFIG_GPIO_I8255 Kconfig option is > > introduced; modules wanting access to these functions should select this > > Kconfig option. > > > > Tested-by: Fred Eckert > > Cc: John Hentges > > Cc: Jay Dolan > > Signed-off-by: William Breathitt Gray >=20 > This chip is like 50 years old, but so am I and I am not obsolete, it's a= bout > time that we implement a proper driver for it! >=20 > But I suppose you are not really using the actual discrete i8255 componen= t? > This is certainly used as integrated into some bridge or so? (Should be > mentioned in the commit.) Interestingly, there are some PC/104 devices out there that use actual i8255 components (e.g. Diamond Systems Onyx-MM with its 82C55 chips), but honestly the majority of devices I come across are simply emulating the i8255 interface in an FPGA or similar. I'll adjust the commit to make it clearer that this is a library for i8255-compatible interfaces rather than support for any physical Intel 8255 chip in particular. > > +config GPIO_I8255 > > + tristate >=20 > That's a bit terse :D Explain that this is a Intel 8255 PPI chip first de= veloped > in the first half of the 1970ies. Ack. > > +++ b/include/linux/gpio/i8255.h >=20 > You need to provide a rationale for the separate .h file in the commit > message even if it is clear > how it is used in the following patches. >=20 > Yours, > Linus Walleij I think I'll move this to gpio/driver.h as per Andy Shevchenko's suggestion. For now only a few drivers under drivers/gpio/ use this library, so it probably doesn't need to be separate just yet. William Breathitt Gray --fPnMJIDMmtvaXDMm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCYszlPwAKCRC1SFbKvhIj K6XQAPsGMPk87IYm745/bAEVZHWvSsrlNwY4SzSB5oTrN+AIZQD8DzVx0wrQCj2q T0ZU22f9J/0Q9p1IMNMCxTcJ9+zJIAs= =v5f6 -----END PGP SIGNATURE----- --fPnMJIDMmtvaXDMm--