From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Molly Sophia <mollysophia379@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map
Date: Sun, 7 Aug 2022 21:19:37 -0700 [thread overview]
Message-ID: <YvCO2SfpXtTfawW5@ripper> (raw)
In-Reply-To: <20220807122645.13830-2-mollysophia379@gmail.com>
On Sun 07 Aug 05:26 PDT 2022, Molly Sophia wrote:
> Currently in the wakeirq_map, gpio36 and gpio37 have the same wakeirq
> number, resulting in gpio37 being unable to trigger interrupts.
> It looks like that this is a typo in the wakeirq map. So fix it.
>
Thank you for finding this, I've been scratching my head about the
i2c-hid interrupts on this gpio for a while now. This indeed looks like
a typo, and the documentation confirms that 44 is the correct PDC irq
line.
> Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
Fixes: 97423113ec4b ("pinctrl: qcom: Add sc8180x TLMM driver")
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-sc8180x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> index 6bec7f143134..b4bf009fe23e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> @@ -1582,7 +1582,7 @@ static const int sc8180x_acpi_reserved_gpios[] = {
> static const struct msm_gpio_wakeirq_map sc8180x_pdc_map[] = {
> { 3, 31 }, { 5, 32 }, { 8, 33 }, { 9, 34 }, { 10, 100 }, { 12, 104 },
> { 24, 37 }, { 26, 38 }, { 27, 41 }, { 28, 42 }, { 30, 39 }, { 36, 43 },
> - { 37, 43 }, { 38, 45 }, { 39, 118 }, { 39, 125 }, { 41, 47 },
> + { 37, 44 }, { 38, 45 }, { 39, 118 }, { 39, 125 }, { 41, 47 },
> { 42, 48 }, { 46, 50 }, { 47, 49 }, { 48, 51 }, { 49, 53 }, { 50, 52 },
> { 51, 116 }, { 51, 123 }, { 53, 54 }, { 54, 55 }, { 55, 56 },
> { 56, 57 }, { 58, 58 }, { 60, 60 }, { 68, 62 }, { 70, 63 }, { 76, 86 },
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-08-08 4:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 12:26 [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Molly Sophia
2022-08-07 12:26 ` [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map Molly Sophia
2022-08-08 4:19 ` Bjorn Andersson [this message]
2022-08-07 12:26 ` [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers Molly Sophia
2022-08-08 4:17 ` Bjorn Andersson
2022-08-22 8:57 ` [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvCO2SfpXtTfawW5@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mollysophia379@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).