From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Molly Sophia <mollysophia379@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers
Date: Sun, 7 Aug 2022 21:17:02 -0700 [thread overview]
Message-ID: <YvCOPn85G3tKlc/l@ripper> (raw)
In-Reply-To: <20220807122645.13830-3-mollysophia379@gmail.com>
On Sun 07 Aug 05:26 PDT 2022, Molly Sophia wrote:
> The pin numbers for UFS_RESET and SDC2_* are not
> consistent in the pinctrl driver for sc8180x.
> So fix it.
>
> Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
Fixes: 97423113ec4b ("pinctrl: qcom: Add sc8180x TLMM driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-sc8180x.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> index b4bf009fe23e..704a99d2f93c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> @@ -530,10 +530,10 @@ DECLARE_MSM_GPIO_PINS(187);
> DECLARE_MSM_GPIO_PINS(188);
> DECLARE_MSM_GPIO_PINS(189);
>
> -static const unsigned int sdc2_clk_pins[] = { 190 };
> -static const unsigned int sdc2_cmd_pins[] = { 191 };
> -static const unsigned int sdc2_data_pins[] = { 192 };
> -static const unsigned int ufs_reset_pins[] = { 193 };
> +static const unsigned int ufs_reset_pins[] = { 190 };
> +static const unsigned int sdc2_clk_pins[] = { 191 };
> +static const unsigned int sdc2_cmd_pins[] = { 192 };
> +static const unsigned int sdc2_data_pins[] = { 193 };
>
> enum sc8180x_functions {
> msm_mux_adsp_ext,
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-08-08 4:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 12:26 [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Molly Sophia
2022-08-07 12:26 ` [PATCH 1/2] pinctrl: qcom: sc8180x: Fix gpio_wakeirq_map Molly Sophia
2022-08-08 4:19 ` Bjorn Andersson
2022-08-07 12:26 ` [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers Molly Sophia
2022-08-08 4:17 ` Bjorn Andersson [this message]
2022-08-22 8:57 ` [PATCH 0/2] Fix some typos in SC8180X pinctrl driver Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvCOPn85G3tKlc/l@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mollysophia379@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).