From: Colin Foster <colin.foster@in-advantage.com>
To: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Terry Bowman <terry.bowman@amd.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Wolfram Sang <wsa@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
UNGLinuxDriver@microchip.com,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
katie.morris@in-advantage.com,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Dan Williams <dan.j.williams@intel.com>,
Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v16 mfd 8/8] mfd: ocelot: add support for the vsc7512 chip via spi
Date: Mon, 15 Aug 2022 07:19:13 -0700 [thread overview]
Message-ID: <YvpV4cvwE0IQOax7@euler> (raw)
In-Reply-To: <20220815005553.1450359-9-colin.foster@in-advantage.com>
Add Lee - My apologies, it seems like you got a new email address and I
didn't copy it on this series.
On Sun, Aug 14, 2022 at 05:55:53PM -0700, Colin Foster wrote:
> The VSC7512 is a networking chip that contains several peripherals. Many of
> these peripherals are currently supported by the VSC7513 and VSC7514 chips,
> but those run on an internal CPU. The VSC7512 lacks this CPU, and must be
> controlled externally.
>
> Utilize the existing drivers by referencing the chip as an MFD. Add support
> for the two MDIO buses, the internal phys, pinctrl, and serial GPIO.
>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>
> v16
> * Includes fixups:
> * ocelot-core.c add includes device.h, export.h, iopoll.h, ioport,h
> * ocelot-spi.c add includes device.h, err.h, errno.h, export.h,
> mod_devicetable.h, types.h
> * Move kconfig.h from ocelot-spi.c to ocelot.h
> * Remove unnecessary byteorder.h
Something is going on that I don't fully understand with <asm/byteorder.h>.
I don't quite see how ocelot-core is throwing all sorts of errors in x86
builds now:
https://patchwork.hopto.org/static/nipa/667471/12942993/build_allmodconfig_warn/stderr
Snippet from there:
/home/nipa/nipa/tests/patch/build_32bit/build_32bit.sh: line 21: ccache gcc: command not found
../drivers/mfd/ocelot-spi.c: note: in included file (through ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ../include/linux/sched.h, ...):
../arch/x86/include/asm/bitops.h:66:1: warning: unreplaced symbol 'return'
../drivers/mfd/ocelot-spi.c: note: in included file (through ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ../include/linux/sched.h, ...):
../include/asm-generic/bitops/generic-non-atomic.h:29:9: warning: unreplaced symbol 'mask'
../include/asm-generic/bitops/generic-non-atomic.h:30:9: warning: unreplaced symbol 'p'
../include/asm-generic/bitops/generic-non-atomic.h:32:10: warning: unreplaced symbol 'p'
../include/asm-generic/bitops/generic-non-atomic.h:32:16: warning: unreplaced symbol 'mask'
../include/asm-generic/bitops/generic-non-atomic.h:27:1: warning: unreplaced symbol 'return'
../drivers/mfd/ocelot-spi.c: note: in included file (through ../arch/x86/include/asm/bitops.h, ../include/linux/bitops.h, ../include/linux/kernel.h, ../arch/x86/include/asm/percpu.h, ../arch/x86/include/asm/current.h, ...):
../include/asm-generic/bitops/instrumented-non-atomic.h:26:1: warning: unreplaced symbol 'return'
<asm/byteorder.h> was included in both drivers/mfd/ocelot-spi.c and
drivers/mfd/ocelot.h previously, though Andy pointed out there didn't
seem to be any users... and I didn't either. I'm sure there's something
I must be missing.
> * Utilize resource_size() function
>
next prev parent reply other threads:[~2022-08-15 14:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 0:55 [PATCH v16 mfd 0/8] add support for VSC7512 control over SPI Colin Foster
2022-08-15 0:55 ` [PATCH v16 mfd 1/8] mfd: ocelot: add helper to get regmap from a resource Colin Foster
2022-08-15 0:55 ` [PATCH v16 mfd 2/8] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Colin Foster
2022-08-15 0:55 ` [PATCH v16 mfd 3/8] pinctrl: ocelot: " Colin Foster
2022-08-15 0:55 ` [PATCH v16 mfd 4/8] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module Colin Foster
2022-08-15 0:55 ` [PATCH v16 mfd 5/8] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Colin Foster
2022-08-15 0:55 ` [PATCH v16 mfd 6/8] resource: add define macro for register address resources Colin Foster
2022-08-15 0:55 ` [PATCH v16 mfd 7/8] dt-bindings: mfd: ocelot: add bindings for VSC7512 Colin Foster
2022-08-15 0:55 ` [PATCH v16 mfd 8/8] mfd: ocelot: add support for the vsc7512 chip via spi Colin Foster
2022-08-15 14:19 ` Colin Foster [this message]
2022-08-15 14:35 ` Ido Schimmel
2022-08-15 14:59 ` Colin Foster
2022-08-16 8:52 ` Andy Shevchenko
2022-08-16 15:20 ` Colin Foster
2022-08-18 19:26 ` Andy Shevchenko
2022-08-18 20:40 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvpV4cvwE0IQOax7@euler \
--to=colin.foster@in-advantage.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=katie.morris@in-advantage.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=lee.jones@linaro.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=terry.bowman@amd.com \
--cc=vladimir.oltean@nxp.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).