build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Sudip Mukherjee (Codethink)]

Hi All,

The builds of riscv, s390, csky, alpha and loongarch allmodconfig have
failed to build next-20220906 with the error:


drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
  311 | static int pci1xxxx_gpio_resume(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
  295 | static int pci1xxxx_gpio_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~


git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.").

I will be happy to test any patch or provide any extra log if needed.


-- 
Regards
Sudip

Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Greg Kroah-Hartman]

On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink) wrote:
> Hi All,
> 
> The builds of riscv, s390, csky, alpha and loongarch allmodconfig have
> failed to build next-20220906 with the error:
> 
> 
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
>   311 | static int pci1xxxx_gpio_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
>   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~
> 
> 
> git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.").
> 
> I will be happy to test any patch or provide any extra log if needed.

Hopefully this commit will fix this:
	https://lore.kernel.org/r/20220906124951.696776-1-kumaravel.thiagarajan@microchip.com


thanks,

greg k-h

Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Sudip Mukherjee]

Hi Greg,

On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink) wrote:
> > Hi All,
> >
> > The builds of riscv, s390, csky, alpha and loongarch allmodconfig have
> > failed to build next-20220906 with the error:
> >
> >
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> >   311 | static int pci1xxxx_gpio_resume(struct device *dev)
> >       |            ^~~~~~~~~~~~~~~~~~~~
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> >   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> >       |            ^~~~~~~~~~~~~~~~~~~~~
> >
> >
> > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.").
> >
> > I will be happy to test any patch or provide any extra log if needed.
>
> Hopefully this commit will fix this:
>         https://lore.kernel.org/r/20220906124951.696776-1-kumaravel.thiagarajan@microchip.com

No, it didn't.  :(

Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think
pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under
"#ifdef CONFIG_PM_SLEEP".


-- 
Regards
Sudip

Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Greg Kroah-Hartman]

On Tue, Sep 06, 2022 at 10:07:53PM +0100, Sudip Mukherjee wrote:
> Hi Greg,
> 
> On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink) wrote:
> > > Hi All,
> > >
> > > The builds of riscv, s390, csky, alpha and loongarch allmodconfig have
> > > failed to build next-20220906 with the error:
> > >
> > >
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> > >   311 | static int pci1xxxx_gpio_resume(struct device *dev)
> > >       |            ^~~~~~~~~~~~~~~~~~~~
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> > >   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> > >       |            ^~~~~~~~~~~~~~~~~~~~~
> > >
> > >
> > > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.").
> > >
> > > I will be happy to test any patch or provide any extra log if needed.
> >
> > Hopefully this commit will fix this:
> >         https://lore.kernel.org/r/20220906124951.696776-1-kumaravel.thiagarajan@microchip.com
> 
> No, it didn't.  :(
> 
> Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think
> pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under
> "#ifdef CONFIG_PM_SLEEP".

Great, Kumaravel, can you send a fixup patch for this?

thanks,

greg k-h

Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Arnd Bergmann]

On Tue, Sep 6, 2022, at 11:07 PM, Sudip Mukherjee wrote:
> On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>> On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink) wrote:
>> >
>> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
>> >   311 | static int pci1xxxx_gpio_resume(struct device *dev)
>> >       |            ^~~~~~~~~~~~~~~~~~~~
>> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
>> >   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
>> >       |            ^~~~~~~~~~~~~~~~~~~~~
>> >
>> >
>> > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.").
>> >
>
> Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think
> pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under
> "#ifdef CONFIG_PM_SLEEP".

That would work, but a better fix is to use DEFINE_SIMPLE_DEV_PM_OPS()
in place of the deprecated SIMPLE_DEV_PM_OPS().

     Arnd

RE: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Kumaravel.Thiagarajan]

> -----Original Message-----
> From: Arnd Bergmann <arnd@arndb.de>
> Sent: Wednesday, September 7, 2022 2:12 PM
> To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>; Greg Kroah-
> Hartman <gregkh@linuxfoundation.org>
> Cc: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>; open list:GPIO SUBSYSTEM
> <linux-gpio@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>;
> linux-next <linux-next@vger.kernel.org>
> Subject: Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
> microchip: pci1xxxx: Add power management functions - suspend & resume
> handlers.")
> 
> 
> On Tue, Sep 6, 2022, at 11:07 PM, Sudip Mukherjee wrote:
> > On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >> On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink)
> wrote:
> >> >
> >> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
> 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> >> >   311 | static int pci1xxxx_gpio_resume(struct device *dev)
> >> >       |            ^~~~~~~~~~~~~~~~~~~~
> >> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
> 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> >> >   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> >> >       |            ^~~~~~~~~~~~~~~~~~~~~
> >> >
> >> >
> >> > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add
> power management functions - suspend & resume handlers.").
> >> >
> >
> > Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think
> > pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under
> > "#ifdef CONFIG_PM_SLEEP".
Thank you Sudip ! I will review this.
> 
> That would work, but a better fix is to use DEFINE_SIMPLE_DEV_PM_OPS()
> in place of the deprecated SIMPLE_DEV_PM_OPS().
Thank you Arnd ! I will review this.

RE: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Kumaravel.Thiagarajan]

> -----Original Message-----
> From: Sudip Mukherjee (Codethink) <sudipm.mukherjee@gmail.com>
> Sent: Tuesday, September 6, 2022 7:53 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>
> Cc: Arnd Bergmann <arnd@arndb.de>; linux-gpio@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-next@vger.kernel.org
> Subject: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip:
> pci1xxxx: Add power management functions - suspend & resume handlers.")
> 
> Hi All,
> 
> The builds of riscv, s390, csky, alpha and loongarch allmodconfig have failed
> to build next-20220906 with the error:
> 
> 
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
> 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
>   311 | static int pci1xxxx_gpio_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
> 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
>   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~
> 
> 
> git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power
> management functions - suspend & resume handlers.").
> 
> I will be happy to test any patch or provide any extra log if needed.
Sudip, can you please share the .config file that you used for riscv and if possible other .config files too?

Thank You.

Regards,
Kumaravel

Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Sudip Mukherjee]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

On Fri, Sep 9, 2022 at 4:12 PM <Kumaravel.Thiagarajan@microchip.com> wrote:
>
> > -----Original Message-----
> > From: Sudip Mukherjee (Codethink) <sudipm.mukherjee@gmail.com>
> > Sent: Tuesday, September 6, 2022 7:53 PM
> > To: Kumaravel Thiagarajan - I21417
> > <Kumaravel.Thiagarajan@microchip.com>; Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>; linux-gpio@vger.kernel.org; linux-
> > kernel@vger.kernel.org; linux-next@vger.kernel.org
> > Subject: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip:
> > pci1xxxx: Add power management functions - suspend & resume handlers.")
> >
> > Hi All,
> >
> > The builds of riscv, s390, csky, alpha and loongarch allmodconfig have failed
> > to build next-20220906 with the error:
> >
> >
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
> > 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> >   311 | static int pci1xxxx_gpio_resume(struct device *dev)
> >       |            ^~~~~~~~~~~~~~~~~~~~
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
> > 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> >   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> >       |            ^~~~~~~~~~~~~~~~~~~~~
> >
> >
> > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power
> > management functions - suspend & resume handlers.").
> >
> > I will be happy to test any patch or provide any extra log if needed.
> Sudip, can you please share the .config file that you used for riscv and if possible other .config files too?

Sure, here is the one for loongarch and riscv. Please let me know if
you need the others and I can generate them for you. These are just
the normal allmodconfig nothing special.
Not sure what you are trying to see here, but imho, you will see the
problem if you check the definition of SET_SYSTEM_SLEEP_PM_OPS in
include/linux/pm.h.


-- 
Regards
Sudip

[-- Attachment #2: loongarch_allmodconfig.gz --]
[-- Type: application/gzip, Size: 75985 bytes --]

[-- Attachment #3: riscv_allmodconfig.gz --]
[-- Type: application/gzip, Size: 76030 bytes --]

RE: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

[Kumaravel.Thiagarajan]

> -----Original Message-----
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Sent: Friday, September 9, 2022 11:22 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Arnd Bergmann
> <arnd@arndb.de>; linux-gpio@vger.kernel.org; linux-kernel <linux-
> kernel@vger.kernel.org>; linux-next <linux-next@vger.kernel.org>
> Subject: Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
> microchip: pci1xxxx: Add power management functions - suspend & resume
> handlers.")
> 
> On Fri, Sep 9, 2022 at 4:12 PM <Kumaravel.Thiagarajan@microchip.com>
> wrote:
> >
> > > -----Original Message-----
> > > From: Sudip Mukherjee (Codethink) <sudipm.mukherjee@gmail.com>
> > > Sent: Tuesday, September 6, 2022 7:53 PM
> > > To: Kumaravel Thiagarajan - I21417
> > > <Kumaravel.Thiagarajan@microchip.com>; Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org>
> > > Cc: Arnd Bergmann <arnd@arndb.de>; linux-gpio@vger.kernel.org;
> > > linux- kernel@vger.kernel.org; linux-next@vger.kernel.org
> > > Subject: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
> microchip:
> > > pci1xxxx: Add power management functions - suspend & resume
> > > handlers.")
> > >
> > > Hi All,
> > >
> > > The builds of riscv, s390, csky, alpha and loongarch allmodconfig
> > > have failed to build next-20220906 with the error:
> > >
> > >
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
> > > 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-
> function]
> > >   311 | static int pci1xxxx_gpio_resume(struct device *dev)
> > >       |            ^~~~~~~~~~~~~~~~~~~~
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
> > > 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-
> function]
> > >   295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> > >       |            ^~~~~~~~~~~~~~~~~~~~~
> > >
> > >
> > > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add
> > > power management functions - suspend & resume handlers.").
> > >
> > > I will be happy to test any patch or provide any extra log if needed.
> > Sudip, can you please share the .config file that you used for riscv and if
> possible other .config files too?
> 
> Sure, here is the one for loongarch and riscv. Please let me know if you need
> the others and I can generate them for you. These are just the normal
> allmodconfig nothing special.
> Not sure what you are trying to see here, but imho, you will see the problem
> if you check the definition of SET_SYSTEM_SLEEP_PM_OPS in
> include/linux/pm.h.
Sudip, Thank you for sharing additional information and it helped so much.

Regards,
Kumaravel