Re: [PATCH 2/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Thu, Sep 08, 2022 at 02:17:54PM +0200, Krzysztof Kozlowski wrote:
> On 06/09/2022 15:19, Russell King (Oracle) wrote:
> > Add the DT binding for the Apple Mac System Management Controller GPIOs.
> > 
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > ---
> >  .../devicetree/bindings/gpio/gpio-macsmc.yaml | 28 +++++++++++++++++++
> >  .../devicetree/bindings/mfd/apple,smc.yaml    |  4 +++
> >  2 files changed, 32 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml
> > new file mode 100644
> > index 000000000000..ee620fe50ca8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml
> > @@ -0,0 +1,28 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Apple Mac System Management Controller GPIO
> > +
> > +maintainers:
> > +  - Hector Martin <marcan@marcan.st>
> > +
> > +description:
> > +  This describes the binding for the Apple Mac System Management Controller
> > +  GPIO block.
> > +
> > +properties:
> > +  gpio-controller: true
> > +  '#gpio-cells':
> > +    const: 2
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    smc_gpio: gpio {
> > +      gpio-controller;
> > +      #gpio-cells = <2>;
> > +    };
> > diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml
> > index 168f237c2962..47e3cd58bf19 100644
> > --- a/Documentation/devicetree/bindings/mfd/apple,smc.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml
> > @@ -37,6 +37,10 @@ title: Apple Mac System Management Controller
> >      description:
> >        A phandle to the mailbox channel
> >  
> > +patternProperties:
> > +  gpio:
> 
> This is not a pattern. Should be in properties.
> 
> Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).

I did. It didn't warn for me. Yes, I had updated it immediately prior.
Yes I had installed the lint package.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!