From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] gpiolib: cdev: export the consumer's PID
Date: Fri, 9 Sep 2022 16:45:17 +0300 [thread overview]
Message-ID: <YxtDbdN0xEOUsKHw@smile.fi.intel.com> (raw)
In-Reply-To: <20220909121329.42004-3-brgl@bgdev.pl>
On Fri, Sep 09, 2022 at 02:13:29PM +0200, Bartosz Golaszewski wrote:
> It's useful for user-space to be able to know the PIDs of processes
> holding GPIO lines in case they have the permissions and need to kill
> them.
>
> Extend the gpio_v2_line_info structure with the consumer_pid field
> that's set to the PID of the user-space process or 0 if the user lives
> in the kernel.
...
> +int gpiod_request(struct gpio_desc *desc, const char *label)
> +{
> + return gpiod_request_with_pid(desc, label, 0);
Why not -1? I would expect this is the usual way of telling
"don't use this PID".
> +}
...
> + desc_set_pid(desc, 0);
Ditto.
...
> + ret = gpiod_request_commit(desc, label, 0);
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-09 13:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 12:13 [PATCH 0/2] gpiolib: export the consumer's PID to user-space Bartosz Golaszewski
2022-09-09 12:13 ` [PATCH 1/2] gpiolib: un-inline gpiod_request_user() Bartosz Golaszewski
2022-09-09 13:45 ` Andy Shevchenko
2022-09-10 14:51 ` Kent Gibson
2022-09-09 12:13 ` [PATCH 2/2] gpiolib: cdev: export the consumer's PID Bartosz Golaszewski
2022-09-09 13:45 ` Andy Shevchenko [this message]
2022-09-09 13:48 ` Andy Shevchenko
2022-09-09 19:18 ` Bartosz Golaszewski
2022-09-10 14:52 ` Kent Gibson
2022-09-12 8:52 ` Bartosz Golaszewski
2022-09-12 9:53 ` Kent Gibson
2022-09-12 9:56 ` Bartosz Golaszewski
2022-09-13 2:12 ` Kent Gibson
2022-09-13 8:54 ` Bartosz Golaszewski
2022-09-13 14:28 ` Kent Gibson
2022-09-13 14:35 ` Bartosz Golaszewski
2022-09-13 14:55 ` Kent Gibson
2022-09-13 15:58 ` Bartosz Golaszewski
2022-09-13 16:17 ` Kent Gibson
2022-09-13 17:07 ` Andy Shevchenko
2022-09-13 19:35 ` Bartosz Golaszewski
2022-09-14 1:00 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxtDbdN0xEOUsKHw@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).