From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Jianqun Xu <jay.xu@rock-chips.com>,
Linus Walleij <linus.walleij@linaro.org>,
jbx6244@gmail.com, brgl@bgdev.pl, linux-gpio@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 RESEND 0/2] rockchip pinctrl for acpi
Date: Fri, 23 Sep 2022 13:33:21 +0300 [thread overview]
Message-ID: <Yy2LcZmdaN3t898E@smile.fi.intel.com> (raw)
In-Reply-To: <2419940.Icojqenx9y@phil>
On Fri, Sep 23, 2022 at 12:26:06PM +0200, Heiko Stuebner wrote:
> Am Dienstag, 20. September 2022, 11:26:26 CEST schrieb Linus Walleij:
> > On Sat, Sep 17, 2022 at 8:09 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> >
> > > These patch fixes to support acpi by:
> > > 1. populate gpio platform before pinctrl to probe
> > > 2. get gpiochip by finding from gpiochip list
> > > 3. get match data by device api
> > >
> > > Jianqun Xu (2):
> > > pinctrl: rockchip: find gpiochip by name from gpio module
> > > pinctrl: rockchip: get match data by device_get_match_data
> >
> > These look OK to me but I would feel better if Heiko or Andy ACK:ed
> > them so I give them a few more days to comment.
>
> Right now I'm actually quite confused as I seem to have a bunch
> of pinctrl/gpio-acpi patchsets of varying lengths in my inbox.
>
> There is a "v2", a "v8", a 20-patchset without version.
> It's all quite confusing.
With the LKP complains on top of almost each series...
That's why I stopped considering them seriously (like some RFC is going on)
and no more reviewing.
I can suggest the author to create a branch on a public tree and collect all
series together (like topic branches that are merged one-by-one to the main
topic branch) and start again.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-23 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 6:09 [PATCH v2 RESEND 0/2] rockchip pinctrl for acpi Jianqun Xu
2022-09-17 6:09 ` [PATCH v2 1/2] pinctrl: rockchip: find gpiochip by name from gpio module Jianqun Xu
2022-09-17 6:09 ` [PATCH v2 2/2] pinctrl: rockchip: get match data by device_get_match_data Jianqun Xu
2022-09-20 9:26 ` [PATCH v2 RESEND 0/2] rockchip pinctrl for acpi Linus Walleij
2022-09-23 10:26 ` Heiko Stuebner
2022-09-23 10:33 ` Andy Shevchenko [this message]
[not found] ` <202209231835365953827@rock-chips.com>
2022-09-23 10:50 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy2LcZmdaN3t898E@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox