From: Colin Foster <colin.foster@in-advantage.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
UNGLinuxDriver@microchip.com,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Vladimir Oltean <olteanv@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 12/14] dt-bindings: net: dsa: ocelot: add ocelot-ext documentation
Date: Fri, 23 Sep 2022 11:18:33 -0700 [thread overview]
Message-ID: <Yy34edNkKopsETcg@colin-ia-desktop> (raw)
In-Reply-To: <35ba126d-be10-2566-63df-3c474cdc8887@linaro.org>
On Fri, Sep 23, 2022 at 08:08:53PM +0200, Krzysztof Kozlowski wrote:
> On 22/09/2022 06:01, Colin Foster wrote:
> > diff --git a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml
> > index 8d93ed9c172c..bed575236261 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml
> > @@ -54,9 +54,21 @@ description: |
> > - phy-mode = "1000base-x": on ports 0, 1, 2, 3
> > - phy-mode = "2500base-x": on ports 0, 1, 2, 3
> >
> > + VSC7412 (Ocelot-Ext):
> > +
> > + The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513,
> > + and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS
> > + processor that natively support Linux. Additionally, all four devices
> > + support control over external interfaces, SPI and PCIe. The Ocelot-Ext
> > + driver is for the external control portion.
> > +
> > + The following PHY interface type are currently supported:
> > + - phy-mode = "internal": on ports 0, 1, 2, 3
>
> "Currently supported" by hardware or by some specific, chosen
> implementation? If the latter, drop it. If the former, maybe this should
> be constrained in allOf:if:then.
Hi Krzysztof,
Currently supported by the software. This patch set explicitly adds
support for the four internal ports. There'll be another patch set right
around the corner that'll add QSGMII to ports 4-7.
I see your point though. I'll drop "currently" and have it match the
wording of the other drivers.
next prev parent reply other threads:[~2022-09-23 18:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 4:00 [PATCH v2 net-next 00/14] add support for the the vsc7512 internal copper phys Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 01/14] net: mscc: ocelot: expose ocelot wm functions Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 02/14] net: mscc: ocelot: expose regfield definition to be used by other drivers Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 03/14] net: mscc: ocelot: expose stats layout " Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 04/14] net: mscc: ocelot: expose vcap_props structure Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 05/14] net: mscc: ocelot: expose ocelot_reset routine Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 06/14] net: dsa: felix: add configurable device quirks Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 07/14] net: dsa: felix: populate mac_capabilities for all ports Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 08/14] net: dsa: felix: update init_regmap to be string-based Colin Foster
2022-09-23 2:39 ` Jakub Kicinski
2022-09-23 2:40 ` Jakub Kicinski
2022-09-23 15:53 ` Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 09/14] pinctrl: ocelot: avoid macro redefinition Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 10/14] mfd: ocelot: prepend resource size macros to be 32-bit Colin Foster
2022-09-22 4:00 ` [PATCH v2 net-next 11/14] mfd: ocelot: add regmaps for ocelot_ext Colin Foster
2022-09-22 4:01 ` [PATCH v2 net-next 12/14] dt-bindings: net: dsa: ocelot: add ocelot-ext documentation Colin Foster
2022-09-23 18:08 ` Krzysztof Kozlowski
2022-09-23 18:18 ` Colin Foster [this message]
2022-09-23 18:31 ` Krzysztof Kozlowski
2022-09-22 4:01 ` [PATCH v2 net-next 13/14] net: dsa: ocelot: add external ocelot switch control Colin Foster
2022-09-22 4:01 ` [PATCH v2 net-next 14/14] mfd: " Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy34edNkKopsETcg@colin-ia-desktop \
--to=colin.foster@in-advantage.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).